Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Use Logger implementation based on deployment configuration #29600

Closed
m2-assistant bot opened this issue Aug 17, 2020 · 2 comments · Fixed by #27379
Closed

[Issue] Use Logger implementation based on deployment configuration #29600

m2-assistant bot opened this issue Aug 17, 2020 · 2 comments · Fixed by #27379
Labels
Component: Logger Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2020 •
edited by engcom-Delta
Loading

This issue is automatically created based on existing pull request: #27379: Use Logger implementation based on deployment configuration

Summary (*)

Magento 2.4-develop
Use Logger implementation based on deployment configuration

Examples (*)

  • Configure Magento to run in production mode
  • Add 'log' => [ 'type' => \Monolog\Logger::class, 'args' => ['name' => 'test']], line to app/etc/env.php file
  • Delete var/log folder
  • Run bin/magento s:s:d
  • Test that errors is logged to StdError stream
  • Test that var/log folder is not exists/empty

Proposed solution
@m2-assistant m2-assistant bot added Component: Logger Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020
@kandy kandy mentioned this issue Aug 17, 2020
Merged
5 tasks
@ghost ghost assigned kandy Aug 17, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 17, 2020
@ghost ghost added this to Ready for QA in Community Backlog Aug 17, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Aug 17, 2020
@ghost ghost unassigned kandy Sep 14, 2020
@ghost ghost moved this from PR In Progress to Ready for QA in Community Backlog Sep 14, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@sidolov sidolov moved this from Ready for Grooming to Ready for Development in Low Priority Backlog Oct 21, 2020
@ghost ghost moved this from Ready for Development to Pull Request In Progress in Low Priority Backlog Oct 21, 2020
@ghost ghost removed this from Ready for QA in Community Backlog Oct 21, 2020
@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Nov 11, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Delta
Thank you for verifying the issue. Based on the provided information internal tickets MC-39025 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Nov 11, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Nov 11, 2020
@gabrieldagama
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #27379 by @kandy in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@gabrieldagama gabrieldagama added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Nov 13, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Done in Low Priority Backlog Nov 13, 2020
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in Low Priority Backlog Nov 13, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Low Priority Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Logger Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Logger implementation based on deployment configuration kandy/magento2
4 participants
@kandy @gabrieldagama @magento-engcom-team @engcom-Delta