[Issue] Add missing order_data array to EmailSender classes

[m2-assistant]

This issue is automatically created based on existing pull request: #27454: Add missing order_data array to EmailSender classes

---

Summary (*)

Magento 2.4-develop
Magento 2.3.4 now recommends using scalar variables instead of objects within the email templates. Unfortunately, not all classes were migrated. For example, \Magento\Sales\Model\order\Email\Sender\ShipmentSender was given the new array, despite now it being deprecated, but its replacement, \Magento\Sales\Model\Order\Shipment\Sender\EmailSender did not.

This change was introduced in commits like fd721b1#diff-7b993c70d2652919564eeaf30afe7326. Several more do change the email templates to use order_data instead.

Examples (*)

1. Create a shipment email template using {{order_data.is_not_virtual}} (as opposed to {{order.is_not_virtual}});
2. Send it programatically using \Magento\Sales\Model\Order\Shipment\Sender\EmailSender;

Proposed solution

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-Delta
Thank you for verifying the issue. Based on the provided information internal tickets MC-38328 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[magento-engcom-team]

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #27454 by @kassner in 2.4-develop branch
Related commit(s):

• 1000822c16ddb32a483b3966bd5e01e7cfcad536
• 56f8bf8dcdfd47d656fc563c8d77c80997268923
• 145d1897dd06bfe0ea0613cf95a8694ef43f3c54

The fix will be available with the upcoming 2.4.2 release.