Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Change selected identifier #29644

Closed
4 tasks
m2-assistant bot opened this issue Aug 18, 2020 · 2 comments · Fixed by #25627
Closed
4 tasks

[Issue] Change selected identifier #29644

m2-assistant bot opened this issue Aug 18, 2020 · 2 comments · Fixed by #25627
Assignees
@brosenberger
Labels
Area: Admin UI Component: Cms Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 18, 2020

This issue is automatically created based on existing pull request: #25627: Change selected identifier

Description (*)

magento can translate contents only when adding new blocks, assigned to different stores with the same identifier. when adding a cms block e.g. within a cms page a cms block widget can add the relation as {{widget .... }}. the id is chosen for the widget to load the block. this will break any translation possibility as one id can not contain multiple translations.
as the widget loads blocks by id or identifier without any further changes the identifier is now selected on selection.

Manual testing scenarios (*)

  1. go to a cms page
  2. add a cms block widget
  3. click show/hide editor
  4. see if block identifier is chosen for the widgets attribute
  5. go to cms page, see if block is correctly shown

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Cms Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 18, 2020
@brosenberger brosenberger mentioned this issue Aug 18, 2020
Merged
5 tasks
@ghost ghost added this to Ready for QA in Community Backlog Aug 18, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 18, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Aug 18, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR in progress labels Sep 24, 2020
@engcom-Lima engcom-Lima added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Admin UI labels Mar 13, 2023
@m2-community-project m2-community-project bot removed this from PR In Progress in Community Backlog Mar 13, 2023
@m2-community-project m2-community-project bot added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Mar 13, 2023
@engcom-Lima engcom-Lima added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 13, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-8247 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Mar 13, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Low Priority Backlog Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brosenberger brosenberger

Labels
Area: Admin UI Component: Cms Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change selected identifier brosenberger/magento2
4 participants
@brosenberger @magento-engcom-team @engcom-Lima @github-jira-sync-bot