Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] [BUGFIX] Also set the Quantity for the product for correct tier pricing #29655

Closed
4 tasks
m2-assistant bot opened this issue Aug 18, 2020 · 6 comments
Closed
4 tasks
Labels
Area: Pricing Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: GraphQL Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 18, 2020

This issue is automatically created based on existing pull request: #28893: [BUGFIX] Also set the Quantity for the product for correct tier pricing


Description (*)

When you retrieve a cart through GraphQl after a quantity update for a product with tier pricing the single unit price is returned.

Manual testing scenarios (*)

  1. Add a product with a tier price to the cart
  2. Change the Quantity
  3. Generate customer token through graphql
  4. Retrieve the cart through the cart call
    query {
    cart(cart_id: "SJRzyxm0GV04kZO53OtHD7KwgYhzpVWB"){
    items {
    uid
    quantity
    product{
    name
    sku
    price_tiers {
    quantity
    final_price {
    value
    }
    discount {
    amount_off
    percent_off
    }
    }
    }
    prices{
    price{
    value
    }
    }
    }
    prices {
    discounts {
    label
    amount {
    value
    }
    }
    subtotal_excluding_tax {
    value
    }
    applied_taxes {
    label
    amount {
    value
    }
    }
    }
    }
    }

Expected result:
correct tier price has been applied
Actual result:
price for quantity one is returned.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: QuoteGraphQl Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 18, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 18, 2020
@ghost ghost assigned lewisvoncken Aug 18, 2020
@ghost ghost added this to Ready for QA in Community Backlog Aug 18, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Aug 18, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR in progress labels Sep 24, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 24, 2020
@sidolov sidolov added this to Pull Request In Progress in High Priority Backlog Oct 20, 2020
@ghost ghost removed this from PR In Progress in Community Backlog Oct 20, 2020
@ghost ghost removed this from Pull Request In Progress in Low Priority Backlog Oct 20, 2020
@ghost ghost added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 20, 2020
@m2-community-project m2-community-project bot added the Severity: S1 Affects critical data or functionality and forces users to employ a workaround. label Feb 10, 2022
@engcom-November engcom-November self-assigned this Sep 12, 2022
@m2-assistant
Copy link
Author

m2-assistant bot commented Sep 12, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Verified the issue on Magento 2.4-develop branch and the issue is reproducible. Hence updating the description and confirming the issue.
Tier price for only quantity one is retrieved in the graphql response.
image
image

@engcom-November engcom-November added Component: GraphQL GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Project: GraphQL Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Pricing Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Component: QuoteGraphQl Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 13, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6672 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Sep 13, 2022

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Oct 21, 2022
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Feb 28, 2023
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Feb 28, 2023
@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: dev in progress labels Mar 20, 2023
@engcom-November
Copy link
Contributor

Development team is currently working on this issue.
Thank you.

@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in High Priority Backlog May 19, 2023
@m2-community-project m2-community-project bot removed the Progress: PR Created Indicates that Pull Request has been created to fix issue label May 19, 2023
@engcom-Hotel
Copy link
Contributor

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-6672 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-6672&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Pricing Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: GraphQL Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Development

Successfully merging a pull request may close this issue.

5 participants