Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure of connections to UPS XML/USPS/DHL API will cause the checkout to break #29902

Closed
1 of 5 tasks
sven-codeculture opened this issue Sep 4, 2020 · 4 comments
Closed
1 of 5 tasks
Labels
Issue: ready for confirmation Reported on 2.3.5-p2 Indicates original Magento version for the Issue report. stale issue

Comments

@sven-codeculture
Copy link

sven-codeculture commented Sep 4, 2020

Magento Version: 2.3.5-p2 (Enterprise)

Preconditions (*)

  1. Either UPS XML/UPSP/DHL Shipping is configured in Magento 2
  2. Either UPS XML/USPS/DHL API is completely down or blocked or the DNS could not be resolved

Steps to reproduce (*)

  1. configure the DHL API for shipping
  2. block the connection to the XML API for DHL or change your environments /etc/resolve.conf to values that prevent the DNS from fetching correctly
  3. Add some item into cart
  4. Go onto the checkout page

Expected result (*)

  1. Checkout is shown with all other configured shipping methods, customer is noted, that DHL shipping is currently not available
  2. Error log is written

Actual result (*)

  1. The window.checkoutConfig variable is not rendered to the DOM wich cause the whole checkout to stop working

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

The only way to work around this is to disable the shipping method completely. If this is not noticed by any admin, it will prevent customers from ordering.

For us it was hour Host having a problem with their DNS server and not resolving the DHL API which caused the checkout to break. Only workaround was changing DNS Servers or disabling the shipping.

@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2020

Hi @sven-codeculture. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Grooming in Low Priority Backlog Sep 4, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 4, 2020
@sven-codeculture
Copy link
Author

I've created three workaround patches that will prevent the checkout from breaking. This however will not give the customer any info that there is a problem with the methods he is shown. It only skips the shipping method on error.

carrier-dhl-offline.txt
carrier-ups-offline.txt
carrier-usps-offline.txt

This patches can be applyed automatically in the module using cweagans/composer-patches module (when installing with composer).

@sven-codeculture
Copy link
Author

sven-codeculture commented Sep 4, 2020

I've tried this out on a fresh m2.3.5-p2 instance without any data. It does not fully stop the checkout from working but it does not allow you to select any shipping method at all if the error occurred in any shipping method.
It also gives an error message on frontend in this case:
Bildschirmfoto 2020-09-04 um 14 04 24
For testing i disconnected the developing mashine from the network.

@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@sidolov sidolov added this to Ready for Confirmation in Issue Confirmation and Triage Board Oct 20, 2020
@ghost ghost removed this from Ready for Grooming in Low Priority Backlog Oct 20, 2020
@ghost ghost added Issue: ready for confirmation and removed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Oct 20, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.5-p2 Indicates original Magento version for the Issue report. label Nov 13, 2020
@stale
Copy link

stale bot commented Jan 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Jan 28, 2021
@stale stale bot closed this as completed Feb 12, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: ready for confirmation Reported on 2.3.5-p2 Indicates original Magento version for the Issue report. stale issue
Projects
None yet
Development

No branches or pull requests

2 participants