Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Fix URL generation for new store when it created with setup:config:import #30025

Closed
4 tasks
m2-assistant bot opened this issue Sep 14, 2020 · 2 comments · Fixed by #30023
Closed
4 tasks

[Issue] Fix URL generation for new store when it created with setup:config:import #30025

m2-assistant bot opened this issue Sep 14, 2020 · 2 comments · Fixed by #30023
Assignees
Labels
Component: Deploy Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2020

This issue is automatically created based on existing pull request: #30023: Fix URL generation for new store when it created with setup:config:import


Preconditions (*)

Magento 2.4-develop

Emulate adminhtml area where url rewrites are created

Related Pull Requests

Fixed Issues (if relevant)

  1. N/A

Steps to reproduce: (*)

  1. On Dev. env setup only one store view with few categories and products
  2. dump stores info to config.php with php bin/magento app:config:dump and commit it

Screenshot from 2020-10-09 11-37-34

  1. Deploy to production (run php bin/magento setup:upgrade --keep-generated on production env)
  2. On dev. env create second store view in the same Store Group and Website in config.php file

2020-10-09_11-39

  1. Deploy to production (run php bin/magento setup:upgrade --keep-generated on production env)
  2. Go to Admin- > Marketing -> URL Rewrites;

Actual Result: ✖️ On second store view URL rewrites were generated only on dev env (it was created via admin), but they weren't generated on production env.

Screenshot from 2020-10-09 10-25-12

Expected Result: ✔️ On second store view on dev and production environments were generated URL rewrites for categories and products.

Questions or comments

My investigation shown that only in adminhtml area URL rewrites are generated when store view is created:

<type name="Magento\Store\Model\ResourceModel\Store">
<plugin name="store_plugin" type="Magento\CatalogUrlRewrite\Model\Category\Plugin\Store\View"/>
</type>
<type name="Magento\Store\Model\ResourceModel\Group">
<plugin name="group_plugin" type="Magento\CatalogUrlRewrite\Model\Category\Plugin\Store\Group"/>
</type>

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@ghost ghost assigned ihor-sviziev Sep 14, 2020
@ghost ghost added this to Ready for QA in Community Backlog Sep 14, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Sep 14, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 14, 2020
@ghost ghost added Progress: PR in progress Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. and removed Progress: ready for QA labels Sep 14, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@engcom-Alfa engcom-Alfa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Oct 9, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 9, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-38327 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Oct 9, 2020
@ghost ghost unassigned ihor-sviziev Oct 9, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in Low Priority Backlog Oct 9, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for dev labels Oct 9, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Oct 15, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #30023 by @ihor-sviziev in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Low Priority Backlog Oct 15, 2020
@m2-community-project m2-community-project bot added Progress: done and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 15, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from PR In Progress in Community Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Deploy Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants