Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic Search issue with Synonyms #30104

Closed
soumiktuban opened this issue Sep 18, 2020 · 21 comments · Fixed by #30614
Closed

Elastic Search issue with Synonyms #30104

soumiktuban opened this issue Sep 18, 2020 · 21 comments · Fixed by #30614
Assignees
Labels
Component: Elasticsearch Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@soumiktuban
Copy link

soumiktuban commented Sep 18, 2020

Preconditions (*)

  1. Magento 2.3.*.
  2. Elasticsearch 6+

Also reproducible on 2.4-develop with Elasticsearch7

Steps to reproduce (*)

  1. Enable Elasticsearch 6+
  2. Add a product with a long name with a slash / in it.
    Example: LSS 3/8"X3/4"X25' EZ-PULL 1/2" INS SWEAT LINESET W/90 END BEND SUCTION LINE INSULATED
  3. Add Search Synonyms with a word belongs to the product name.
    Example: center end boot,torpedo boot,horn boot,register boot center end,register boot torpedo
  4. Search in the frontend for that exact product.

Expected result (*)

  1. Find that particular product without errors.

Actual result (*)

  1. Error report: {"0":"Warning: preg_match(): Unknown modifier '8' in /vendor/magento/module-search/Model/SynonymAnalyzer.php on line 96","1":"Can you commit to repository a folder dev/tests/static ? #1 preg_match() called at [vendor/magento/module-search/Model/SynonymAnalyzer.php:96]\n#2 Magento\Search\Model\SynonymAnalyzer->findInArray() called at [vendor/magento/module-search/Model/SynonymAnalyzer.php:71]

Additional info

  1. Create a product with below product name as mentioned earlier:
    image

  2. Create a Search Synonyms (Marketing -> Search Synonyms) and clear the cache as mentioned earlier:
    image

  3. Copy the entire product name and search in frontend.
    image

  4. Hit enter
    image

  5. Here is the message from the report:
    image

  6. Here is my configuration:
    image

@m2-assistant
Copy link

m2-assistant bot commented Sep 18, 2020

Hi @soumiktuban. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Ready for QA in Community Backlog Sep 18, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 18, 2020
@engcom-Oscar engcom-Oscar self-assigned this Sep 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 21, 2020

Hi @engcom-Oscar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Oscar
Copy link

Hello @soumiktuban

Thank you for your report.
Unfortunately, I was not able to reproduce this issue on the latest 2.4-develop code. Probably it was already fixed and will appear in the next release. Or we missed some steps or preconditions.

Could you please recheck it on clean Magento 2.4 installation and confirm?

@soumiktuban
Copy link
Author

I don't have a system ready for Magento 2.4 right now. Kindly keep it open till I get a system to confirm.
Please let me know if this issue can be fixed by using a patch on Magento 2.3.*.

Thanks :)

@engcom-Oscar
Copy link

Sorry, but we are able to process, collaborate, fix, and deliver pull requests ONLY for Issues that can be reproduced on the latest 2.4-develop public branch.

@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Dev In Progress in Low Priority Backlog Sep 24, 2020
@engcom-Oscar engcom-Oscar added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Oct 1, 2020
@soumiktuban
Copy link
Author

Hello @engcom-Oscar

This issue is still reproducible on Magento 2.4
Below snaps are the steps to reproduce the issue:

  1. Create a product with below product name as mentioned earlier:
    image

  2. Create a Search Synonyms (Marketing -> Search Synonyms) and clear the cache as mentioned earlier:
    image

  3. Copy the entire product name and search in frontend.
    image

  4. Hit enter
    image

  5. Here is the message from the report:
    image

  6. Here is my configuration:
    image

Hope this will help you to reproduce the issue.

Thanks,
Soumik

@soumiktuban
Copy link
Author

@engcom-Oscar @magento-engcom-team
Any update?
Are you able to reproduce this issue?

@soumiktuban
Copy link
Author

@magento-engcom-team @engcom-Oscar - Any update?

@engcom-Oscar engcom-Oscar removed their assignment Oct 19, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Grooming in Low Priority Backlog Oct 19, 2020
@engcom-Bravo engcom-Bravo self-assigned this Oct 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 19, 2020

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@m2-community-project m2-community-project bot moved this from Ready for Grooming to Dev In Progress in Low Priority Backlog Oct 19, 2020
@engcom-Bravo engcom-Bravo removed the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Oct 20, 2020
@denchev
Copy link
Contributor

denchev commented Oct 22, 2020

I can reproduce the issue so @magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Oct 22, 2020

Hi @denchev! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@denchev
Copy link
Contributor

denchev commented Oct 22, 2020

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Oct 22, 2020

Hi @denchev! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@denchev
Copy link
Contributor

denchev commented Oct 22, 2020

@magento I am working on this

@ghost ghost moved this from Ready for Development to Dev In Progress in High Priority Backlog Oct 22, 2020
@sidolov sidolov added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Oct 23, 2020
@ghost ghost moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Oct 23, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Nov 27, 2020
@magento-engcom-team
Copy link
Contributor

Hi @soumiktuban. Thank you for your report.
The issue has been fixed in #30614 by @denchev in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Nov 27, 2020
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in High Priority Backlog Nov 27, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Aug 24, 2021
@m2-community-project m2-community-project bot moved this from Ready for Development to Done in High Priority Backlog Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Elasticsearch Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Development

Successfully merging a pull request may close this issue.

8 participants