-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
\Error object not handled properly in numerous areas. #30149
Comments
Hi @dfelton. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @engcom-Delta. Thank you for working on this issue.
|
✅ Confirmed by @engcom-Delta Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
Hi @engcom-Kilo. Thank you for working on this issue.
|
Preconditions (*)
Steps to reproduce (*)
cms_page_save_after
event. Contents:Expected result (*)
\Magento\Cms\Controller\Adminhtml\Page\Save::execute()
is written to catch objects of\Throwable
, it should pass to\Magento\Framework\Message\ManagerInterface
an object that will be accepted.Actual result (*)
\Throwable
, and passes toManagerInterface::addExceptionMessage()
an instance of\Error
(or\TypeError
, which extends\Error
), and sinceaddExceptionMessage()
only accepts objects which are an instance of\Exception
rather than\Throwable
, yet another\TypeError
is thrown. This\TypeError
trickles up to the catch statement in\Magento\Framework\App\Bootstrap::run()
which catches objects of\Throwable
, and the application is terminated./Error
object before fixOriginal expected result:
\Magento\Framework\EntityManager\Operation\Update::execute()
should roll back the mysql transaction\Magento\Framework\EntityManager\Opteration\Create::execute()
should roll back the mysql transaction\Magento\Framework\Model\ResourceModel\Db\AbstractDb::save()
, the transaction should be rolled back here as well.\Magento\Cms\Controller\Adminhtml\Page\Save::execute()
is written to catch objects of\Throwable
, it should pass to\Magento\Framework\Message\ManagerInterface
an object that will be accepted.Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.
Since this requires customization to the application to occur, I will not mark any of the Severity issues, as I have not found any occurrences where this issue is able to be reproduced from native stock code. However, I believe there to clearly be areas in the core code where revisions are appropriate to handle these situations more properly.
The text was updated successfully, but these errors were encountered: