Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAP][GraphQL] resetPassword mutation returns generic error #30179

Closed
magento-engcom-team opened this issue Sep 23, 2020 · 5 comments · Fixed by #30230
Closed

[PAP][GraphQL] resetPassword mutation returns generic error #30179

magento-engcom-team opened this issue Sep 23, 2020 · 5 comments · Fixed by #30230
Labels
Component: CustomerGraphQl Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development PAP Partners acceleration program Priority: P3 May be fixed according to the position in the backlog. Progress: done Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Milestone

Comments

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 23, 2020

While implementing resetPassword functionality into PWA, an engineer ran into a problem that resulted in this generic error response: Cannot set the customer's password. It took digging through the exception log to discover the provided password didn't meet the minimum password requirements, which was not in the error message.

<2020-08-11 19:59:26] report.ERROR: Cannot set the customer's password {"exception":"[object] (GraphQL\\Error\\Error(code: 0): Cannot set the customer's password at /app/vendor/webonyx/graphql-php/src/Error/Error.php:174, Magento\\Framework\\GraphQl\\Exception\\GraphQlInputException(code: 0): Cannot set the customer's password at /app/vendor/magento/module-customer-graph-ql/Model/Resolver/ResetPassword.php:121, Magento\\Framework\\Exception\\InputException(code: 0): Minimum of different classes of characters in password is 3. Classes of characters: Lower Case, Upper Case, Digits, Special Characters. at /app/vendor/magento/module-customer/Model/AccountManagement.php:764)"} [>

Repro Steps:

  1. Execute requestPasswordResetEmail mutation and extract token from email
  2. Execute resetPassword mutation with a weak password in newPassword field

Expected: Error is returned with language explaining password didn't meet specific requirements (message from exception log)
Actual: Cannot set the customer's password

image (3) (1)
image (2) (1)

@magento-engcom-team magento-engcom-team added Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 23, 2020
@magento-engcom-team
Copy link
Contributor Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-36648

@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 23, 2020
@m2-community-project m2-community-project bot added this to Ready for Development in Low Priority Backlog Sep 23, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Ready for Grooming in Low Priority Backlog Sep 23, 2020
@prabhuram93 prabhuram93 added PAP Partners acceleration program Project: GraphQL labels Sep 23, 2020
@prabhuram93 prabhuram93 moved this from Ready for Grooming to Ready for Development in Low Priority Backlog Sep 23, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Ready for Grooming in Low Priority Backlog Sep 23, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Ready for Development in Low Priority Backlog Sep 23, 2020
@m2-community-project m2-community-project bot added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 23, 2020
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 23, 2020
@magento-engcom-team
Copy link
Contributor Author

@m2-community-project[bot] Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess
  • Update issue content to follow format required by Issue Reporting Guidelines

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2020

Hi @sudheers-kensium. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in Low Priority Backlog Sep 23, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Dev In Progress in Low Priority Backlog Sep 24, 2020
@magento-engcom-team magento-engcom-team changed the title [GraphQL] resetPassword mutation returns generic error [PAP][GraphQL] resetPassword mutation returns generic error Oct 2, 2020
@nrkapoor nrkapoor added this to the 2.4.2 milestone Oct 6, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in Low Priority Backlog Oct 7, 2020
@sudheers-kensium sudheers-kensium added Component: CustomerGraphQl Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 8, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 8, 2020
@magento-engcom-team
Copy link
Contributor Author

✅ Confirmed by @sudheers-kensium
Thank you for verifying the issue. Based on the provided information internal tickets MC-38312 were created

Issue Available: @sudheers-kensium, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sudheers-kensium sudheers-kensium added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Oct 8, 2020
@m2-community-project m2-community-project bot removed the Progress: PR Created Indicates that Pull Request has been created to fix issue label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CustomerGraphQl Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development PAP Partners acceleration program Priority: P3 May be fixed according to the position in the backlog. Progress: done Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Development

Successfully merging a pull request may close this issue.

4 participants