Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Fix PHPDoc param attribute is not always a string #30191

Closed
4 tasks done
m2-assistant bot opened this issue Sep 24, 2020 · 1 comment · Fixed by #30182
Closed
4 tasks done

[Issue] Fix PHPDoc param attribute is not always a string #30191

m2-assistant bot opened this issue Sep 24, 2020 · 1 comment · Fixed by #30182
Assignees
Labels
Component: Sales Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Sep 24, 2020

This issue is automatically created based on existing pull request: #30182: Fix PHPDoc param attribute is not always a string


Description (*)

Fix PHPDoc param attribute is not always a string

In the implementation:

if ($attribute instanceof AbstractAttribute) {
    $attributes = $attribute->getAttributeCode();
} elseif (is_string($attribute)) {
    $attributes = [$attribute];
} else {
    $attributes = $attribute;
}

Manual testing scenarios (*)

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable) / N/A
  • All automated tests passed successfully (all builds are green) / N/A
@m2-assistant m2-assistant bot added Component: Sales Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Sep 24, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 24, 2020
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 24, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 30, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #30182 by @FredericMartinez in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Low Priority Backlog Sep 30, 2020
@m2-community-project m2-community-project bot added Progress: done and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants