Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Passing arguments for queues as expected #30216

Closed
4 tasks
m2-assistant bot opened this issue Sep 28, 2020 · 2 comments · Fixed by #26966
Closed
4 tasks

[Issue] Passing arguments for queues as expected #30216

m2-assistant bot opened this issue Sep 28, 2020 · 2 comments · Fixed by #26966
Labels
Component: MessageQueue Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Sep 28, 2020 •
edited by engcom-Bravo
Loading

This issue is automatically created based on existing pull request: #26966: Passing arguments for queues as expected

Description (*)

According to docs it should be possible to declare queue with arguments (like dead-letter-exchange or message-ttl). Unfortunately during process of setting up rabbite schema, arguments are lost and queues are declared without any arguments.

It is because here arguements are always empty array. PR fixes this and also adds return type and some minor formatting fixes. If there are any tests for these class I will fix them as soon as bug will be reproduced, confirmed and my solution will be accepted.
If PR will be accepted, please port to 2.3 as well.

Preconditions (*)

Magento 2.4-develop

Steps to reproduce (*)

  1. Create some schema for rabbit using magento xml queue_topology.xml, like in dev docs.
  2. Check if queue is declared in rabbit with arguments (for testing use real arguments like message ttl)

Expected result (*)

Que is declared

Actual result (*)

Que is not declared

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: MessageQueue Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 28, 2020
@m2-assistant m2-assistant bot mentioned this issue Sep 28, 2020
Merged
5 tasks
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 28, 2020
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Sep 28, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 28, 2020
@ghost ghost unassigned bartoszkubicki Oct 23, 2020
@ghost ghost added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 23, 2020
@engcom-Bravo engcom-Bravo added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Oct 28, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 28, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-38761 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ghost ghost moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Oct 28, 2020
@ghost ghost moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Oct 28, 2020
@gabrieldagama gabrieldagama added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Nov 9, 2020
@gabrieldagama
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #26966 by @bartoszkubicki in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@m2-community-project m2-community-project bot moved this from Ready for Development to Done in Low Priority Backlog Nov 9, 2020
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in Low Priority Backlog Nov 9, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Low Priority Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: MessageQueue Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Passing arguments for queues as expected bartoszkubicki/magento2
4 participants
@gabrieldagama @bartoszkubicki @magento-engcom-team @engcom-Bravo