Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] #29174 Add save_rewrites_history to categories via API #30240

Closed
4 tasks
m2-assistant bot opened this issue Sep 30, 2020 · 2 comments · Fixed by #29205
Closed
4 tasks

[Issue] #29174 Add save_rewrites_history to categories via API #30240

m2-assistant bot opened this issue Sep 30, 2020 · 2 comments · Fixed by #29205
Assignees
Labels
Component: CatalogUrlRewrite Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Sep 30, 2020

This issue is automatically created based on existing pull request: #29205: #29174 Add save_rewrites_history to categories via API


Support save_rewrites_history to categories API

Preconditions (*)

  1. Magento 2.4-develop

Description (*)

See #29174

Fixed Issues (if relevant)

  1. Fixes Category API should support save_rewrites_history for consistency reasons #29174

Steps to reproduce (*)

  1. Go to Catalog - Categories and create a new Subcategory
  2. Open Swagger (http://magentositewname.domain/swagger)
  3. Generate Admin token via integrationAdminTokenServiceV1 POST /V1/integration/admin/token request
  4. Copy the generated token into api_key field and click **apply
    api_key_field
  5. Perform the catalogCategoryRepositoryV1 PUT /V1/categories/{id} request with the following Parameters:
  • id 2 (id of the previously created category)
  • body
{
    "category": {
    "id": 5,
    "parent_id": 2,
    "name": "new name",
    "is_active": true,
    "position": 0,
    "level": 0,
    "created_at": "string",
    "updated_at": "string",
    "path": "string",
    "include_in_menu": true,
    "extension_attributes": {},
    "custom_attributes": [
      {
        "attribute_code": "url_key",
        "value": "new name1"
      },{
        "attribute_code":"save_rewrites_history",
        "value":1
        }
      ]
     }
    }
  1. Verify if the Response body is correct.
    Example:
    resp_body
  2. Open database table url_rewrite

Actual result (*)

The old url_rewriew record has been removed, and only the new record existed
db_before11

db_before2

Expected result (*)

The previous record is not removed
db_after1

See example in #29174

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: CatalogUrlRewrite Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Sep 30, 2020
@m2-community-project m2-community-project bot added this to Ready for Grooming in Low Priority Backlog Sep 30, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 30, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 30, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 30, 2020
@engcom-Bravo engcom-Bravo added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Sep 30, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 30, 2020
@engcom-Bravo engcom-Bravo added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 30, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-38102 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: ready for dev and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 30, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Sep 30, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 30, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Done in Low Priority Backlog Sep 30, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogUrlRewrite Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants