Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error if admin enters wrong values for some customer attribute and uploads file #30295

Closed
magento-engcom-team opened this issue Oct 1, 2020 · 9 comments · Fixed by #30963
Assignees
Labels
CD Issue recommended for the contribution day Component: Other Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 1, 2020

If Admin tries to save customer entering not valid values for some attribute which has Input Validation set up, and uploads file at the same time he gots fatal error.

Please note: if you just enter wrong value for some attribute XOR upload file you will not get fatal.

Steps to Reproduce:

  1. Create new Customer attribute for URL (Stores -> Attributes -> Customer):

* Input Type = Text Field

* Values Required = Yes

* Default Value = www.google.com

* Input Validation = URL

  1. Create new Customer attribute for file:

* Input Type = File

* Values Required = Yes

  1. Create new customer:

* URL field - leave default value

* File attribute - upload some image

  1. Fill all other required fields
  2. Click Save button

Actual Result:
(-) Fatal Error
Note: if you click back button in browser or open some other page in backend you will see error messages about field which had wrong values

Expected Result:
(/) Error message appears for each field which has wrong value

@magento-engcom-team magento-engcom-team added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Oct 1, 2020
@magento-engcom-team
Copy link
Contributor Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-33687

@m2-assistant
Copy link

m2-assistant bot commented Oct 1, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Grooming in Low Priority Backlog Oct 1, 2020
@magento-engcom-team magento-engcom-team added Component: Other Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Oct 1, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Ready for Development in Low Priority Backlog Oct 1, 2020
@magento-engcom-team
Copy link
Contributor Author

✅ Confirmed by @magento-engcom-team
Thank you for verifying the issue. Based on the provided information internal tickets MC-33687 were created

Issue Available: @magento-engcom-team, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 1, 2020
@sivaschenko sivaschenko added the CD Issue recommended for the contribution day label Oct 7, 2020
@Yash-Bhayani
Copy link

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Oct 10, 2020

Hi @Yash-Bhayani! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@Yash-Bhayani
Copy link

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Oct 10, 2020

Hi @Yash-Bhayani! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@Yash-Bhayani
Copy link

@magento I am working on this

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in Low Priority Backlog Oct 10, 2020
@sidolov sidolov added this to Dev In Progress in High Priority Backlog Oct 20, 2020
@ghost ghost removed this from Dev In Progress in Low Priority Backlog Oct 20, 2020
@ghost ghost unassigned Yash-Bhayani Nov 4, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog Nov 4, 2020
@sdzhepa sdzhepa added the Reported on 2.3.5 Indicates original Magento version for the Issue report. label Nov 11, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Nov 18, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Nov 25, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 25, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 25, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Nov 26, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Nov 26, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 26, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Nov 26, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CD Issue recommended for the contribution day Component: Other Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
5 participants