Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Clean code and remove whitespace in markup layered navigation filters #30448

Closed
1 of 4 tasks
m2-assistant bot opened this issue Oct 12, 2020 · 2 comments · Fixed by #30333
Closed
1 of 4 tasks

[Issue] Clean code and remove whitespace in markup layered navigation filters #30448

m2-assistant bot opened this issue Oct 12, 2020 · 2 comments · Fixed by #30333
Assignees
@mrtuvn
Labels
Component: LayeredNavigation Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 12, 2020

This issue is automatically created based on existing pull request: #30333: Clean code and remove whitespace in markup layered navigation filters

Description (*)

This pr aim to clean whitespace in some inline elements inside layered filter items. Also update use $escaper instead $block in template

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Luma theme
Results before change
before_remove

Results after change
after_remove

Blank theme
Results before change
blank_category

Results after change
blank_category_fix

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: LayeredNavigation Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 12, 2020
@m2-assistant m2-assistant bot mentioned this issue Oct 12, 2020
Merged
5 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Oct 12, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 12, 2020
@engcom-Alfa engcom-Alfa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 12, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 12, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-38345 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot added Progress: ready for dev and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 12, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Oct 12, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #30333 by @mrtuvn in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Oct 13, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Done in Low Priority Backlog Oct 13, 2020
@sdzhepa sdzhepa added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Nov 11, 2020
@magento-engcom-team magento-engcom-team added Reported on 2.4.0 Indicates original Magento version for the Issue report. and removed Reported on 2.4.x Indicates original Magento version for the Issue report. labels Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrtuvn mrtuvn

Labels
Component: LayeredNavigation Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean code and remove whitespace in markup layered navigation filters mrtuvn/magento2
4 participants
@mrtuvn @sdzhepa @magento-engcom-team @engcom-Alfa