Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Atwix]Category images are broken with SEO disabled #30473

Closed
magento-engcom-team opened this issue Oct 12, 2020 · 3 comments · Fixed by #30689
Closed

[Atwix]Category images are broken with SEO disabled #30473

magento-engcom-team opened this issue Oct 12, 2020 · 3 comments · Fixed by #30689
Assignees
Labels
Mageconf_Contribution_Day Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: GraphQL
Milestone

Comments

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 12, 2020

Cloning this ticket as its the same fix but it needs to also enable for when a customer has URL rewrites turned off (right now it only works if they have it turned on)

Seems like we introduced a bug change to 2.3.4 when we updated the category image source. It was changed from file name to the actual url but doesn't seem to work as the path returned is not the actual path for existing images. Only new images created after the migration work correctly. 

Test instance - https://adobe-starter.dummycachetest.com/graphql/ 

Query 
{
category(id: 21)

{ id name urlpath image product_count childrencount }

}

Expected output 

{
  "data": {
    "category": {
      "id": 31,
      "name": "Tops",
      "url_path": "venia-tops",
      "image": "https://adobe-starter.dummycachetest.com/media/catalog/category/outside.jpg",
      "product_count": 0,
      "children_count": "2"
    }
  }
} {code}
Actual output
{code:java}
 { "data": { "category": { "id": 31, "name": "Tops", "url*path": "venia-tops", "image": "https://adobe-starter.dummycachetest.com/media/outside.jpg", "product_count": 0, "children*count": "2" } } } ```
@magento-engcom-team magento-engcom-team added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev Severity: S0 A problem that is blocking the ability to work. An immediate fix is needed. labels Oct 12, 2020
@magento-engcom-team
Copy link
Contributor Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-38407

@m2-assistant
Copy link

m2-assistant bot commented Oct 12, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Grooming in Low Priority Backlog Oct 12, 2020
@magento-engcom-team magento-engcom-team changed the title Category images are broken after migrating to 2.3.4 [Atwix]Category images are broken after migrating to 2.3.4 Oct 12, 2020
@magento-engcom-team magento-engcom-team added Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. and removed Severity: S0 A problem that is blocking the ability to work. An immediate fix is needed. labels Oct 12, 2020
@nrkapoor nrkapoor added this to the 2.4.2 milestone Oct 18, 2020
@nrkapoor nrkapoor moved this from Ready for Grooming to Good first Issue in Low Priority Backlog Oct 18, 2020
@ghost ghost added this to Ready for Development in GraphQL Backlog Oct 20, 2020
@ghost ghost removed this from Good first Issue in Low Priority Backlog Oct 20, 2020
@ProkopovVitaliy
Copy link
Contributor

@magento I am working on this

@ghost ghost moved this from Ready for Development to Dev In Progress in GraphQL Backlog Oct 28, 2020
@ghost ghost moved this from Dev In Progress to Pull Request In Progress in GraphQL Backlog Oct 28, 2020
@ghost ghost removed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Oct 28, 2020
@magento-engcom-team magento-engcom-team changed the title [Atwix]Category images are broken after migrating to 2.3.4 [Atwix]Category images are broken with SEO disabled Oct 29, 2020
@ghost ghost moved this from Pull Request In Progress to Done in GraphQL Backlog Nov 3, 2020
@magento-engcom-team magento-engcom-team added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mageconf_Contribution_Day Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: GraphQL
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants