Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] MessageValidator fails on hash arrays that dont have 0 element #30563

Closed
3 of 4 tasks
m2-assistant bot opened this issue Oct 20, 2020 · 1 comment · Fixed by #30521
Closed
3 of 4 tasks

[Issue] MessageValidator fails on hash arrays that dont have 0 element #30563

m2-assistant bot opened this issue Oct 20, 2020 · 1 comment · Fixed by #30521
Assignees
@kandy
Labels
Component: MessageQueue Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 20, 2020

This issue is automatically created based on existing pull request: #30521: MessageValidator fails on hash arrays that dont have 0 element

Magento\Framework\MessageQueue\Test\Unit\MessageValidatorTest::testInvalidMessageType with data set #11 (array('object_interface', 'Magento\Customer\Api\Data\Cus...face[]'), array(23, 545), 'Data in topic "topic" must be...e[]". ')
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /magento/lib/internal/Magento/Framework/MessageQueue/MessageValidator.php:157.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: MessageQueue Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Oct 20, 2020
@m2-assistant m2-assistant bot mentioned this issue Oct 20, 2020
Merged
5 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Oct 20, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 20, 2020
@sidolov sidolov added this to Pull Request In Progress in High Priority Backlog Oct 20, 2020
@ghost ghost removed this from Pull Request In Progress in Low Priority Backlog Oct 20, 2020
@ghost ghost added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #30521 by @kandy in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Oct 24, 2020
@ghost ghost moved this from Pull Request In Progress to Done in High Priority Backlog Oct 24, 2020
@ghost ghost moved this from Done to Pull Request In Progress in High Priority Backlog Oct 24, 2020
@sidolov sidolov moved this from Pull Request In Progress to Done in High Priority Backlog Oct 27, 2020
@sdzhepa sdzhepa added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Nov 11, 2020
@magento-engcom-team magento-engcom-team added Reported on 2.4.0 Indicates original Magento version for the Issue report. and removed Reported on 2.4.x Indicates original Magento version for the Issue report. labels Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kandy kandy

Labels
Component: MessageQueue Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MessageValidator fails on hash arrays that dont have 0 element kandy/magento2
3 participants
@kandy @sdzhepa @magento-engcom-team