Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] add --no-tablespaces parameters to mysqldump #30566

Closed
3 of 4 tasks
m2-assistant bot opened this issue Oct 20, 2020 · 1 comment · Fixed by #30502
Closed
3 of 4 tasks

[Issue] add --no-tablespaces parameters to mysqldump #30566

m2-assistant bot opened this issue Oct 20, 2020 · 1 comment · Fixed by #30502
Assignees
@jonashrem
Labels
Component: Crontab Event: MageCONF CD 2020 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 20, 2020

This issue is automatically created based on existing pull request: #30502: add --no-tablespaces parameters to mysqldump

Description (*)

adds --no-tablespaces to all occurrences of mysqldump. With this PR integration tests can run without the PROCESS privilege which is required since MySQL 5.7.31 / 8.0.21 to run mysqldump by default. See also https://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-31.html#mysqld-5-7-31-security or https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-21.html for details

Related Pull Requests

/

Fixed Issues (if relevant)

/

Manual testing scenarios (*)

this only affects the integration tests.

With this PR integration tests can run without the PROCESS privilege which is required since MySQL 5.7.31 to run mysqldump by default.

Questions or comments

/

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Crontab Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 20, 2020
@m2-assistant m2-assistant bot mentioned this issue Oct 20, 2020
Merged
5 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Oct 20, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #30502 by @jonashrem in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Oct 24, 2020
@ghost ghost moved this from Pull Request In Progress to Done in Low Priority Backlog Oct 24, 2020
@ghost ghost moved this from Done to Pull Request In Progress in Low Priority Backlog Oct 24, 2020
@ghost ghost added Progress: done Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 24, 2020
@ghost ghost moved this from Pull Request In Progress to Done in Low Priority Backlog Oct 24, 2020
@sdzhepa sdzhepa added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Nov 11, 2020
@magento-engcom-team magento-engcom-team added Reported on 2.4.0 Indicates original Magento version for the Issue report. and removed Reported on 2.4.x Indicates original Magento version for the Issue report. labels Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonashrem jonashrem

Labels
Component: Crontab Event: MageCONF CD 2020 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add --no-tablespaces parameters to mysqldump jonashrem/magento2
3 participants
@jonashrem @sdzhepa @magento-engcom-team