Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex products children ids are not cached in Type class leading to multiple unnecessary db requests #30585

Closed
PierreLeMaguer opened this issue Jul 26, 2019 · 4 comments · Fixed by #30746
Assignees
Labels
Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.

Comments

@PierreLeMaguer
Copy link
Contributor

PierreLeMaguer commented Jul 26, 2019

Description

in the product page, the method 'getChildrenIds' is called several times and each time we make an SQL request to get this info.
For example juno-jacket.html with the sample data, the method of the configurable type is called 20 times.

The problem
The result of this method is not stored in a cache to avoid to make useless request.

benefits
We earn time by making a cache and storing the results instead of making SQL requests.

Related pull request closed due to inactivity: #23910

@sivaschenko
Copy link
Member

Moving this feature request to magento2 issues as this looks to be a performance bug that should be addressed

@sivaschenko sivaschenko transferred this issue from magento/community-features Oct 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 21, 2020

Hi @PierreLeMaguer. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Ready for Confirmation in Issue Confirmation and Triage Board Oct 21, 2020
@sivaschenko sivaschenko added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Oct 21, 2020
@ghost ghost moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Oct 21, 2020
@sivaschenko sivaschenko added Issue: ready for confirmation Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Oct 21, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 21, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @sivaschenko
Thank you for verifying the issue. Based on the provided information internal tickets MC-38593 were created

Issue Available: @sivaschenko, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ghost ghost added this to Ready for Development in High Priority Backlog Oct 21, 2020
@ghost ghost removed this from Confirmed in Issue Confirmation and Triage Board Oct 21, 2020
@sivaschenko sivaschenko changed the title Avoid to make several times the same request to get children ids of a product Complex products children ids are not cached in Type class leading to multiple unnecessary db requests Oct 21, 2020
@ghost ghost moved this from Ready for Development to Dev In Progress in High Priority Backlog Oct 23, 2020
@ghost ghost moved this from Ready for Development to Dev In Progress in High Priority Backlog Oct 23, 2020
@ihor-sviziev ihor-sviziev added the Area: Perf/Frontend All tickets related with improving frontend performance. label Oct 26, 2020
@ghost ghost moved this from Dev In Progress to Ready for Development in High Priority Backlog Oct 26, 2020
@ihor-sviziev ihor-sviziev removed Area: Perf/Frontend All tickets related with improving frontend performance. Progress: ready for dev labels Oct 26, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Nov 4, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 4, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 4, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Nov 5, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Nov 5, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Nov 9, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Nov 9, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 10, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 10, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Nov 10, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Nov 10, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Nov 10, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Nov 10, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
5 participants