Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Fix iterate on null #30830

Closed
m2-assistant bot opened this issue Nov 6, 2020 · 3 comments · Fixed by #30822
Closed

[Issue] Fix iterate on null #30830

m2-assistant bot opened this issue Nov 6, 2020 · 3 comments · Fixed by #30822
Labels
Component: Shipping Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 6, 2020

This issue is automatically created based on existing pull request: #30822: Fix iterate on null


Preconditions (*)

Magento 2.4-develop
If there is no carriers available on the store (no carriers modules), an iteration on null occurs.

Steps to reproduce

  • Disable shipping modules:
    image
  • Create simple product
  • Go to storefront
  • Add product to cart
  • Go to checkout page

Expected result (*)

  1. No errors is shown on checkout shipping page
    image
  2. Message "Sorry, no quotes are available for this order at this time" is shown
    image

Actual result (*)

  1. Blank checkout page
  2. Error "array_keys() expects parameter 1 to be array, null given" is recorded into exception.log
    image
@m2-assistant m2-assistant bot added Component: Shipping Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 6, 2020
@m2-assistant m2-assistant bot mentioned this issue Nov 6, 2020
1 task
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Nov 6, 2020
@engcom-Delta engcom-Delta added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Nov 20, 2020
@engcom-Delta engcom-Delta self-assigned this Nov 20, 2020
@m2-assistant
Copy link
Author

m2-assistant bot commented Nov 20, 2020

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta engcom-Delta added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Nov 20, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Delta
Thank you for verifying the issue. Based on the provided information internal tickets MC-39291 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #30822 by @thomas-kl1 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Dec 10, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Dec 10, 2020
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in High Priority Backlog Dec 10, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Aug 25, 2021
@m2-community-project m2-community-project bot moved this from Ready for Development to Done in High Priority Backlog Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Shipping Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Development

Successfully merging a pull request may close this issue.

4 participants