ProductUrlSuffix and CategoryUrlSuffix GraphQL resolvers fail with null values

[aligent-lturner]

Preconditions (*)

1. Magento version 2.4.x
2. Magento 2.4-develop

Steps to reproduce (*)

1. Go to Admin -> Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization
2. Clear product and category url suffix values in admin and save

Run GraphQL query that requests product and/or category url suffix value

{
  categoryList {
    url_suffix
  }
}

Expected result: Empty string ('') is returned for url_suffix value

Actual Result: ✖️ Query fails

✖️ with the following error in exception.log:

2020-11-20 13:29:04] main.ERROR: Return value of Magento\CatalogUrlRewriteGraphQl\Model\Resolver\CategoryUrlSuffix::getCategoryUrlSuffix() must be of the type string, null returned {"exception":"[object] (GraphQL\\Error\\Error(code: 0): Return value of Magento\\CatalogUrlRewriteGraphQl\\Model\\Resolver\\CategoryUrlSuffix::getCategoryUrlSuffix() must be of the type string, null returned at /var/www/html/magento24/vendor/webonyx/graphql-php/src/Error/Error.php:174, TypeError(code: 0): Return value of Magento\\CatalogUrlRewriteGraphQl\\Model\\Resolver\\CategoryUrlSuffix::getCategoryUrlSuffix() must be of the type string, null returned at /var/www/html/magento24/app/code/Magento/CatalogUrlRewriteGraphQl/Model/Resolver/CategoryUrlSuffix.php:80)"} []

Additional Information

The problem is that the private functions getProductUrlSuffix and getCategoryUrlSuffix are declared with string as the return type, but when values are cleared in admin config, null gets stored in the core_config_data table. The value being returned by ScopeConfigInterface->getValue should be checked for null and changed to empty string instead.
I will create PR to fix this.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @aligent-lturner. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[magento-engcom-team]

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-39290 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[zakdma]

@magento i am working on it

[aligent-lturner]

@zakdma there is already an approved PR for this issue.

[zakdma]

@aligent-lturner ok
Please assign it to issue

[aligent-lturner]

@zakdma it was referenced - for some reason the bot removed the pr in progress tag.
#30910

[magento-engcom-team]

Hi @aligent-lturner. Thank you for your report.
The issue has been fixed in #30910 by @aligent-lturner in 2.4-develop branch
Related commit(s):

• 5512626bfdfdede24ded8095998c647092d60ebb
• ffcc5234644f0b6813dcbacc120689c372ee7af9
• 673edbeef402cdce35888dcc105261be24184337
• 53ed515634f5a38a04eb32b93a69f12ae6695ab2

The fix will be available with the upcoming 2.4.3 release.