Graphql - issue adding multiple configurable products to cart

[calin-ImDigital]

Preconditions (*)

1. magento 2.3.4

Steps to reproduce (*)

create a mutation for addConfigurableProductsToCart with multiple configurable products

Expected result (*)

1. products added to cart

Actual result (*)

{
"errors": [
{
"message": "You need to choose options for your item.",
"extensions": {
"category": "graphql-input"
},
"locations": [
{
"line": 25,
"column": 3
}
],
"path": [
"addConfigurableProductsToCart"
]
}
],
"data": {
"addConfigurableProductsToCart": null
}
}

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @cdiacon-img. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[nige-one]

I have the same issue. The problem is that in

magento2/app/code/Magento/ConfigurableProductGraphQl/Model/Options/Collection.php

Line 100 in 445b0f1

if (empty($this->productIds) || !empty($this->attributeMap)) {

the !empty($this->attributeMap) does not take into account the case of more then one Configurable Product's super attribute needs to be resolved.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hello @cdiacon-img

Thank you for your report.

Can you please clarify, are you trying to add multiple Products with options using one mutation, or you are trying to add one single configurable product with multiple options?
In any case, could you please provide a mutation example?

Thank you in advance

[calin-ImDigital]

Hi @engcom-Bravo

As I remember it was adding multiple products(cart items) with this mutation

mutation {
#   addConfigurableProductsToCart(
#     input: {
#       cart_id: "QZBii1Eu3vb5tOoGo94Rl9kcnquhc1Nf"
#       cart_items: [
#         {
#           data: {
#             quantity: 1
#             sku: "40012244"
#           },
#           parent_sku: "style-123"
            
#         },
#         {
#           parent_sku: "style-321"
#           data:{
#             quantity: 2
#             sku: "40023175"
#           }
          
#         }
#       ]
#     }
#   ) {
#     cart {
#       items {
#         id
#         product {
#           sku
#           stock_status
#         }
#         quantity
#       }
#     }
#   }
# }

[engcom-Bravo]

@cdiacon-img Thank you for the quick response.

This actually was the mutation we have tried to reproduce with.
The difference is that we are getting a different error

{
  "errors": [
    {
      "message": "Could not add the product with SKU Configurable2 to the shopping cart: Could not find specified product.",
      "extensions": {
        "category": "graphql-input"

This happens when we try to add two products. The Configurable2 itself is added to the Cart successfully.

[calin-ImDigital]

@engcom-Bravo

I am not sure why you are getting product not found but I guess you are hitting the condition of this test

testAddVariationFromAnotherConfigurableProductWithTheSameSuperAttributeToCart

But in my case it was getting attribute data from wrong product
You need to choose options for your item

This is how we patched at the moment, I hope this helps :

---
 vendor/magento/module-configurable-product-graph-ql/Model/Options/Collection.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vendor/magento/module-configurable-product-graph-ql/Model/Options/Collection.php b/vendor/magento/module-configurable-product-graph-ql/Model/Options/Collection.php
index 36ee00d..c8bbe74 100644
--- a/vendor/magento/module-configurable-product-graph-ql/Model/Options/Collection.php
+++ b/vendor/magento/module-configurable-product-graph-ql/Model/Options/Collection.php
@@ -97,7 +97,7 @@ class Collection
      */
     private function fetch() : array
     {
-        if (empty($this->productIds) || !empty($this->attributeMap)) {
+        if (empty($this->productIds)) {
             return $this->attributeMap;
         }

--

[calin-ImDigital]

This is the same thing that @nige-one pointed out above.

[engcom-Bravo]

Hello @cdiacon-img

I'm still getting a different error than the reported.
The following mutation

mutation {
  addConfigurableProductsToCart(
    input: {
      cart_id: "nUdFfPMkIyC3vJS8I6K56Tk0zdPDUpco"
      cart_items: [
        { parent_sku: "Conf1", data: { quantity: 1, sku: "Conf1-white" } }
        { parent_sku: "Conf2", data: { quantity: 1, sku: "Conf2-s" } }
      ]
    }
  ) {
    cart {
      items {
        uid
        quantity
        product {
          name
          sku
        }
        ... on ConfigurableCartItem {
          configurable_options {
            option_label
          }
        }
      }
    }
  }
}

returns

{
  "errors": [
    {
      "message": "Could not add the product with SKU Conf2 to the shopping cart: The product with SKU Conf2 is out of stock.",
      "extensions": {
        "category": "graphql-input"
      },
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "addConfigurableProductsToCart"
      ]
    }
  ],
  "data": {
    "addConfigurableProductsToCart": null
  }
}

It might be that on 2.4-develop the behavior is different. I noticed that you are reporting the issue on 2.3.4. Can you please verify if the issue is reproducible on 2.4-develop for you?

Thank you

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-959 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[github-jira-sync-bot]

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-959

[github-jira-sync-bot]

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-959

[sidolov]

Hi @cdiacon-img. Thank you for your report.
The issue has been fixed in #31654 by @nige-one in 2.4-develop branch
Related commit(s):

• 0b56c80ef86d634f38c6401f07b3cb70650ec4e0
• f46aa2319743da95df200bc56c3a0a34c6a05483
• 6dc64d4c134fe3e8aee59fce2f0f8beacb236830
• 8fcc2851aeb92e40cd8aa1d79114d4074ef202bb

The fix will be available with the upcoming 2.4.3 release.

[calin-ImDigital]

Thanks everyone for a quick fix.

Also, 2.4.3 was released and I can't find the fix?!