Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Update Api functional test install-config-mysql file template #31019

Closed
4 tasks done
m2-assistant bot opened this issue Nov 23, 2020 · 2 comments · Fixed by #30995
Closed
4 tasks done

[Issue] Update Api functional test install-config-mysql file template #31019

m2-assistant bot opened this issue Nov 23, 2020 · 2 comments · Fixed by #30995
Assignees
@dani97
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 23, 2020

This issue is automatically created based on existing pull request: #30995: Update Api functional test install-config-mysql file template

Elasticsearch config is required for 2.4 installation

The api functional tests install-config-mysql.php.dist file template is outdated without elasticsearch params which are required for magento installation in 2.4-develop. Added essential es config params

Description (*)

The magento installation config api functional tests updated with now required elasticsearch parameters from 2.4-develop

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes the config-mysql template

Manual testing scenarios (*)

  1. Change this config template to PHP file
  2. Run api-functional tests with 'test-magento-installation' option enabled in 2.4-develop branch

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 23, 2020
@m2-assistant m2-assistant bot mentioned this issue Nov 23, 2020
Merged
5 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Nov 23, 2020
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 6, 2021
@gabrieldagama gabrieldagama added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 9, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Apr 9, 2021
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in Low Priority Backlog Apr 9, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @gabrieldagama
Thank you for verifying the issue. Based on the provided information internal tickets MC-41836 were created

Issue Available: @gabrieldagama, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ihor-sviziev ihor-sviziev removed the Priority: P3 May be fixed according to the position in the backlog. label Apr 19, 2021
@sidolov
Copy link
Contributor

sidolov commented Oct 24, 2021

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #30995 by @dani97 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

@sidolov sidolov added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Oct 24, 2021
@sidolov sidolov closed this as completed Oct 24, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Oct 24, 2021
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in High Priority Backlog Oct 24, 2021
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dani97 dani97

Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
  
Pull Request In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Api functional test install-config-mysql file template dani97/magento2
5 participants
@ihor-sviziev @gabrieldagama @sidolov @dani97 @magento-engcom-team