Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Fix error message in StockItemValidator.php #31107

Closed
m2-assistant bot opened this issue Dec 1, 2020 · 3 comments · Fixed by #31058
Closed

[Issue] Fix error message in StockItemValidator.php #31107

m2-assistant bot opened this issue Dec 1, 2020 · 3 comments · Fixed by #31058
Assignees
@ferdiusa
Labels
Area: Admin UI Component: CatalogInventory Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 1, 2020

This issue is automatically created based on existing pull request: #31058: Fix error message in StockItemValidator.php

This error message has previously been updated to misleading text and since then lacked the "greater". (see git history/blame)
According to validation logic of the enclosing "if", values of zero are not allowed and will throw this error.

Error got thrown when supplying stock item id with the value of zero during an API call and left the developer scratching his head.
@m2-assistant m2-assistant bot added Component: CatalogInventory Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 1, 2020
@m2-assistant m2-assistant bot mentioned this issue Dec 1, 2020
Merged
1 task
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Dec 1, 2020
@engcom-Lima engcom-Lima added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Admin UI Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: CatalogInventory Area: Admin UI labels Feb 22, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-8005 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Feb 22, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Lima engcom-Lima added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: CatalogInventory Area: Admin UI labels Feb 22, 2023
@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-8005

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Low Priority Backlog Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferdiusa ferdiusa

Labels
Area: Admin UI Component: CatalogInventory Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error message in StockItemValidator.php ferdiusa/magento2
3 participants
@ferdiusa @engcom-Lima @github-jira-sync-bot