Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Magento Coding Standard to version 6 #31152

Closed
sivaschenko opened this issue Dec 3, 2020 · 2 comments · Fixed by #31151
Closed

Update Magento Coding Standard to version 6 #31152

sivaschenko opened this issue Dec 3, 2020 · 2 comments · Fixed by #31151
Assignees
Labels
feature request Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Progress: PR in progress

Comments

@sivaschenko
Copy link
Member

A new version 6 of Magento Coding Standard is available: https://github.com/magento/magento-coding-standard/releases/tag/v6

The composer.lock file should be updated to switch to the new version

@m2-assistant
Copy link

m2-assistant bot commented Dec 3, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Dec 3, 2020
@m2-community-project m2-community-project bot added this to Ready for Grooming in Feature Requests Backlog Dec 3, 2020
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Dec 3, 2020
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. and removed Progress: ready for grooming labels Dec 3, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request in Progress in Feature Requests Backlog Dec 3, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Dec 10, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your report.
The issue has been fixed in #31151 by @ihor-sviziev in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Progress: PR in progress
Projects
Development

Successfully merging a pull request may close this issue.

3 participants