Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] fix for ambigous column user_id in where clause #31216

Closed
m2-assistant bot opened this issue Dec 8, 2020 · 7 comments · Fixed by #31205
Closed

[Issue] fix for ambigous column user_id in where clause #31216

m2-assistant bot opened this issue Dec 8, 2020 · 7 comments · Fixed by #31205
Assignees
Labels
Component: User Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 8, 2020

This issue is automatically created based on existing pull request: #31205: fix for ambigous column user_id in where clause


Magento\Users\Model\ResourceModel\User\Collection addFilterToMap for user_id

Description (*)

When filtering Magento\Users\Model\ResourceModel\Users\Collection by user_id , it throws an SQL exception ( ambigous user_id in where condition )

Preconditions:

Magento version: 2.4-develop
PHP version: 7.4
ElasticSearch version: 7
MySQL version: 8.0

Manual testing scenario:

  1. Add the code from the attached file
    Code_to_reproduce_31205.zip
  2. Run in console: php bin/magento setup:upgrade;
  3. Log in to the admin panel;
  4. open URL /admin/column;

Actual Result: ✖️ 2 exceptions occur

Screenshot from 2021-02-02 15-26-29

Expected Result: ✔️ No exceptions

@m2-assistant m2-assistant bot added Component: User Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Dec 8, 2020
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Dec 8, 2020
@engcom-Hotel
Copy link
Contributor

Not able to reproduce the issue.
M2.4
Steps:

  1. Create a few admin users;
  2. Open admin panel and sort admin users by ID at grid "System > Permissions > All users grid"
    31205_not_able_to_rep

Works as expected. Could you please provide additional information to reproduce the issue?
Thank you.

@engcom-Hotel engcom-Hotel self-assigned this Dec 17, 2020
@m2-assistant
Copy link
Author

m2-assistant bot commented Dec 17, 2020

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel engcom-Hotel added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Dec 17, 2020
@aleron75
Copy link
Contributor

Hi @engcom-Hotel

Works as expected. Could you please provide additional information to reproduce the issue?

Same for me but I managed to reproduce it programmatically as stated here: #31205 (comment)

@engcom-Hotel
Copy link
Contributor

Hello @aleron75,
Yes, it helps to reproduce the issue.
Thank you.
Detailed steps to reproduce #31205 (comment)

@engcom-Hotel engcom-Hotel added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch labels Dec 22, 2020
@engcom-Alfa engcom-Alfa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 3, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-40735 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Feb 3, 2021
@gabrieldagama
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #31205 by @dorupetruc in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Feb 18, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Feb 18, 2021
@m2-community-project m2-community-project bot moved this from Ready for Development to Done in High Priority Backlog Feb 18, 2021
@magento-engcom-team magento-engcom-team removed the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Feb 18, 2021
@magento-engcom-team
Copy link
Contributor

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

Please feel free to comment or reopen according to the Issue reporting guidelines
the ticket if you are still facing this issue on the latest 2.x-develop branch. Thank you for collaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: User Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Development

Successfully merging a pull request may close this issue.

6 participants