Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Bug Fix: Add missing return statement to admin usage enable controller #31374

Closed
1 of 5 tasks
m2-assistant bot opened this issue Dec 21, 2020 · 6 comments · Fixed by #31356
Closed
1 of 5 tasks

[Issue] Bug Fix: Add missing return statement to admin usage enable controller #31374

m2-assistant bot opened this issue Dec 21, 2020 · 6 comments · Fixed by #31356
Assignees
@lbajsarowicz
Labels
Area: Content Component: AdminAnalytics Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 21, 2020

This issue is automatically created based on existing pull request: #31356: Bug Fix: Add missing return statement to admin usage enable controller

Description (*)

Although there is a response-type Docblock declaration, there is no return statement.
This results in invalid handling of the Controller in FrontendController class.

Related Pull Requests

Fixed Issues (if relevant)

  1. Invalid controller handling.

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: AdminAnalytics Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 21, 2020
@m2-assistant m2-assistant bot mentioned this issue Dec 21, 2020
Merged
6 tasks
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Dec 21, 2020
@m2-community-project m2-community-project bot added Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. labels Dec 21, 2020
@stale
Copy link

stale bot commented Mar 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Mar 9, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Mar 9, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Mar 9, 2021
@dverkade
Copy link
Member

This is not a stale issue, PR is in progress and issue is ready for work. This issue can't be closed automatically.

@stale stale bot removed the stale issue label Mar 17, 2021
@engcom-Delta
Copy link
Contributor

Confirming this issue as it is reproducible.

Screenshot 2024-01-18 at 7 23 55 PM Screenshot 2024-01-18 at 7 21 26 PM

@engcom-Delta engcom-Delta added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 18, 2024
@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 18, 2024
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@engcom-Delta engcom-Delta added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Jan 18, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10866 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Jan 18, 2024

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Low Priority Backlog Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbajsarowicz lbajsarowicz

Labels
Area: Content Component: AdminAnalytics Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug Fix: Add missing return statement to admin usage enable controller lbajsarowicz/magento2
4 participants
@dverkade @lbajsarowicz @engcom-Delta @github-jira-sync-bot