Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Replace JSON serializer with JSON Hex Tag (User module) #31377

Closed
4 tasks
m2-assistant bot opened this issue Dec 21, 2020 · 4 comments · Fixed by #31359
Closed
4 tasks

[Issue] Replace JSON serializer with JSON Hex Tag (User module) #31377

m2-assistant bot opened this issue Dec 21, 2020 · 4 comments · Fixed by #31359
Assignees
Labels
Area: UI Framework Component: User Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 21, 2020

This issue is automatically created based on existing pull request: #31359: Replace JSON serializer with JSON Hex Tag (User module)


Description (*)

The serializer injected into the View Model is being used to serialize data for the Store views.
When trying to use the data serialized with a regular Serializer, it ends up on crash when you have unescaped elements in your contents. That is why JsonHexTag class was introduced.

The goal of this PR is to replace the JSON serializer with the more useful/accurate one.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: User Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 21, 2020
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Dec 21, 2020
@m2-community-project m2-community-project bot added Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. labels Dec 21, 2020
@stale
Copy link

stale bot commented Mar 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Mar 9, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Mar 9, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Mar 9, 2021
@dverkade
Copy link
Member

This is not a stale issue, PR is in progress and issue is ready for work. This issue can't be closed automatically.

@stale stale bot removed the stale issue label Mar 17, 2021
@engcom-Lima engcom-Lima added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: UI Framework labels Sep 11, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9489 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Sep 11, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI Framework Component: User Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Development

Successfully merging a pull request may close this issue.

4 participants