Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Allow backend login without redirect #31470

Closed
3 of 5 tasks
m2-assistant bot opened this issue Dec 28, 2020 · 2 comments
Closed
3 of 5 tasks

[Issue] Allow backend login without redirect #31470

m2-assistant bot opened this issue Dec 28, 2020 · 2 comments
Assignees
Labels
Component: Backend Component: Security Component: User Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 28, 2020

This issue is automatically created based on existing pull request: #30950: Allow backend login without redirect


Description (*)

Currently, when accessing a backend page via a direct URL as a logged out admin, the admin is redirected to <backend-url>/admin to log in. After logging in, they are redirected to the admin dashboard (or whatever page is selected as the startup page in system configuration).

This can be frustrating, since the admin now has to manually navigate to the requested page. This also potentially prevents some scripted tasks.

This PR proposes to remove the redirect to <backend-url>/admin, in which case the log in happens on the same page as the requested page (same as M1). The user is directly redirected to the requested page after login.

Related Pull Requests

  • MAGETWO-45465 The proposed code to be removed was added in this commit.

Manual testing scenarios (*)

  1. Add an admin user with a role that allows them to view products (Magento_Catalog::products ACL resource).
  2. Make sure you're logged out from the backend.
  3. Attempt to access <backend-url>/catalog/product/
  4. The login form should be presented to you. Check the URL - you should still be on <backend-url>/catalog/product/ with this PR.
  5. Log in.
  6. You should see the product listing directly (and not be redirected to the startup page).

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Allow backend login without redirect #31042: Allow backend login without redirect
@m2-assistant m2-assistant bot added Component: Backend Component: Security Component: User Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Dec 28, 2020
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Dec 28, 2020
@engcom-Delta engcom-Delta self-assigned this Dec 28, 2020
@m2-assistant
Copy link
Author

m2-assistant bot commented Dec 28, 2020

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

Closed as Duplicate of #31042

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Backend Component: Security Component: User Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Development

No branches or pull requests

2 participants