Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Update lessjs to v3.13.1 #31824

Closed
4 tasks
m2-assistant bot opened this issue Jan 25, 2021 · 2 comments · Fixed by #31618
Closed
4 tasks

[Issue] Update lessjs to v3.13.1 #31824

m2-assistant bot opened this issue Jan 25, 2021 · 2 comments · Fixed by #31618
Assignees
Labels
duplicate Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Milestone

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jan 25, 2021

This issue is automatically created based on existing pull request: #31618: Update lessjs to v3.13.1


Description (*)

Update old version to recently newer
2.3.1 to 3.13.1
Current magento used lessjs v2.3.1.
Official version is https://cdn.jsdelivr.net/npm/less@3.13
https://www.jsdelivr.com/package/npm/less
For maintain compatible we can stay at v3 for a while!. Current official less released v4.1.0

Official less website http://lesscss.org/

This file allow to browser compile less file to css on-flies. Allow developer can check styles from browser without need run deploy ! Note this feature not work in production mode

Idealy lessjs the version should be same as lessphp compile version

Related Pull Requests

Fixed Issues (if relevant)

No issue available

Manual testing scenarios (*)

  1. Enable developer mode
  2. Enable Client side compilation in Advanced Configuration
    (Stores > Configuration > Advanced > Developer
    Frontend Development Workflow => Workflow type : Client side less compilation)
  3. Save and clear cache config admin
  4. Go to frontend and verify page render properly without break or glitch
  5. Change package.json.sample => package.json
  6. Install package by command npm install
  7. from commandline run
    node_modules/.bin/lessc --version and check properly version less

Questions or comments

CC: @Leland @krzksz @ptylek what do you guys think on this ?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jan 25, 2021
@m2-assistant m2-assistant bot mentioned this issue Jan 25, 2021
5 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Jan 25, 2021
@gabrieldagama gabrieldagama added this to the 2.5 milestone Jan 25, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in 2.5 Milestone Backlog Jan 25, 2021
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in High Priority Backlog Jan 25, 2021
@ihor-sviziev
Copy link
Contributor

Hi,

This is duplicate of #32845

@ihor-sviziev
Copy link
Contributor

Duplicates #32845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants