Country isn't translated in customer emails when asyncronous sending is enabled

[martinshawruroc]

Preconditions (*)

1. 2.4.1
2. latest 2.4-develop

Steps to reproduce (*)

1. Create a fresh Magento2 instance, I used https://github.com/markshust/docker-magento with the latest 2.4-develop branch (55c4ff8 at time of writing). I've also replicated the issue on 2.4.1
2. Create a simple product, details are unimportant
3. Create a new store view against the default store/website.
4. Change the locale of that storeview to something else. For my test I set it to German (German). It doesn't matter what language you choose, so long as the country name is different to the default locale (e.g. Germany vs Deutschland) The config can be found at Stores > Config > General > General > Locale.
5. Add a translation so that the locale you've added has at least the country translation. I installed a German language pack which covers this (https://github.com/mageplaza/magento-2-german-language-pack)
6. Configure your website so the new store can be accessed via the frontend. There are a few ways to do this, but I just enabled the Add Store Code to Urls configuration option (Stores > Config > General > Web).
7. Place an order on the newly created storeview for the simple product you created earlier.
8. Observe that in the order confirmation email the country is translated. (https://i.imgur.com/fTbmZ4d.png)
9. Change the system configuration so that async email sending is enabled (Stores > Config > Sales > Sales Emails > General Settings > Asynchronous sending)
10. Place an order on the newly created storeview for the simple product you created earlier.
11. Observe the email hasn't translated the country. (https://i.imgur.com/wrJm4m3.png)

Expected result (*)

Regardless of whether or not the email is send asynchronously or synchronously all parts of the email should be translated to the locale that the order was placed in.

Actual result (*)

When the order email is sent asynchronously for an order with a different locale to the default, it isn't used.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @martinshawruroc. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-40809 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[sanaeefar-saeed]

use email_order_set_template_vars_before event and put this code in your observer to solve this issue

        // Locale needs to be changed based on the order's storeId
        $storeId       = $order->getStoreId();
        $newLocaleCode = $this->scopeConfig->getValue(
            $this->localeResolver->getDefaultLocalePath(),
            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
            $storeId
        );
        $this->localeResolver->setLocale($newLocaleCode);
        $this->translate->setLocale($newLocaleCode);

        $transport['formattedShippingAddress'] = $this->addressRenderer->format($order->getShippingAddress(), 'html');
        $transport['formattedBillingAddress']  = $this->addressRenderer->format($order->getBillingAddress(), 'html');

[onlinebizsoft]

@engcom-Alfa can you make an update? Is this solved in 2.4.3 or recent 2.4-develop updates?

[ronakchauhan]

@onlinebizsoft I tried to reproduce the issue in magento 2.4.2-p2 but i think it's resolved now. so, cant reproduced it.
i have used default magento language pack for german language
https://github.com/splendidinternet/Magento2_German_LocalePack_de_DE
composer install: composer require splendidinternet/mage2-locale-de-de

[joshbourke]

I just ran into this problem. When order emails are sent async, the default locale is not correct.

Strangely enough, the i18n translations are correct, but the following method returns the root locale:
\Magento\Framework\Locale\Resolver::getDefaultLocale

This results in the French emails not having the correct datetime.