Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classes and interfaces part 2 #32057

Open
sivaschenko opened this issue Feb 9, 2021 · 3 comments
Open

Update classes and interfaces part 2 #32057

sivaschenko opened this issue Feb 9, 2021 · 3 comments
Assignees
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: dev in progress Project: API Changes
Milestone

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Feb 9, 2021

Update the following classes and interfaces in 2.5-develop branch

  1. Magento\Framework\Data\Form\Element\Factory Change visibility of protected properties to private
  2. Magento\Customer\Controller\Adminhtml\Index Remove deprecated methods and properties
  3. Magento\Sales\Model\Order\Email\Sender\OrderSender Change visibility of protected properties and methods to private
  4. Magento\Sales\Model\Order\Email\Sender\InvoiceSender Change visibility of protected properties and methods to private
  5. Magento\Customer\Model\Url Change visibility of protected properties to private
  6. Magento\Framework\UrlFactory Change visibility of protected properties to private
  7. Magento\Cms\Model\Template\FilterProvider Change visibility of protected properties to private
  8. Magento\Sales\Model\Service\InvoiceService Change visibility of protected properties to private
  9. Magento\Framework\HTTP\Adapter\Curl Change visibility of protected properties and methods to private
  10. Magento\Framework\Convert\DataObject Change visibility of protected properties and methods to private
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes labels Feb 9, 2021
@sivaschenko sivaschenko added this to the 2.5 milestone Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ProkopovVitaliy
Copy link
Contributor

@magento i am working on this

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in 2.5 Milestone Backlog Feb 10, 2021
@ProkopovVitaliy ProkopovVitaliy removed their assignment Feb 10, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in 2.5 Milestone Backlog Feb 10, 2021
@ProkopovVitaliy
Copy link
Contributor

@magento i am working on this

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in 2.5 Milestone Backlog Feb 11, 2021
@gabrieldagama gabrieldagama changed the title Update classes and interfaces and mark them as API part 2 Update classes and interfaces part 2 Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: dev in progress Project: API Changes
Projects
No open projects
2.5 Milestone Backlog
Dev In Progress
Development

No branches or pull requests

2 participants