Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Fix file upload styles duplication in luma theme #32373

Closed
4 tasks
m2-assistant bot opened this issue Mar 4, 2021 · 4 comments · Fixed by #32354
Closed
4 tasks

[Issue] Fix file upload styles duplication in luma theme #32373

m2-assistant bot opened this issue Mar 4, 2021 · 4 comments · Fixed by #32354
Assignees
Labels
Area: UI Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Mar 4, 2021

This issue is automatically created based on existing pull request: #32354: Fix file upload styles duplication in luma theme


Description (*)

I noticed that styles for file uploader located both in styles-m and styles-l css files that loaded on the page that is not really needed.
In order to fix that - I wrapped all styles to the following section:

& when (@media-common = true) {
   //...original styles here
}

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@stale
Copy link

stale bot commented May 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label May 25, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog May 25, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board May 25, 2021
@ihor-sviziev
Copy link
Contributor

hey, we have an open PR for this issue. Let's keep it open!

@stale stale bot closed this as completed Jun 8, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Low Priority Backlog Jun 8, 2021
@ihor-sviziev ihor-sviziev reopened this Jun 8, 2021
@stale stale bot removed the stale issue label Jun 8, 2021
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in Low Priority Backlog Jun 8, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Low Priority Backlog Oct 20, 2023
@engcom-Hotel engcom-Hotel added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: UI Framework labels Jan 19, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10877 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented Jan 19, 2024

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

3 participants