Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Seperate js out template to avoid render issue #32454

Closed
4 tasks
m2-assistant bot opened this issue Mar 11, 2021 · 2 comments · Fixed by #32434
Closed
4 tasks

[Issue] Seperate js out template to avoid render issue #32454

m2-assistant bot opened this issue Mar 11, 2021 · 2 comments · Fixed by #32434
Assignees
Labels
Component: Backend Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Mar 11, 2021

This issue is automatically created based on existing pull request: #32434: Seperate js out template to avoid render issue


Description (*)

Main purpose of this PR to seperate js out of template avoid mix js-in-php

Previously if we set store to production with minify enabled. When access backend will raise error because phtml can't render properly

Reference var/log/system.log

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Switch to production mode

bin/magento config:set --lock-env dev/template/minify_html 1
bin/magento config:set --lock-env dev/js/enable_js_bundling 0
bin/magento config:set --lock-env dev/js/merge_files 0
bin/magento config:set --lock-env dev/js/minify_files 0
bin/magento config:set --lock-env dev/js/move_script_to_bottom 1
3. Clear cache and run deploy static content for backend area
4. Login to admin

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Backend Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Mar 11, 2021
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Mar 11, 2021
@m2-community-project m2-community-project bot added Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. labels Mar 11, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Mar 11, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Mar 11, 2021
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Apr 6, 2021
@engcom-Oscar engcom-Oscar added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Apr 8, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Apr 8, 2021
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in Low Priority Backlog Apr 8, 2021
@engcom-Oscar engcom-Oscar added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Apr 8, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-41820 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@gabrieldagama
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #32434 by @mrtuvn in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

@gabrieldagama gabrieldagama added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Apr 11, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Apr 11, 2021
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in High Priority Backlog Apr 11, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Aug 25, 2021
@m2-community-project m2-community-project bot moved this from Ready for Development to Done in High Priority Backlog Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Backend Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Development

Successfully merging a pull request may close this issue.

5 participants