Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2 Related Products rule always returns the same products which meet the rule requirements #32489

Open
1 of 5 tasks
mtwegrzycki opened this issue Mar 16, 2021 · 6 comments
Labels
Area: Catalog Component: Catalog Component: Rule Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@mtwegrzycki
Copy link
Contributor

Preconditions (*)

  1. Magento 2.4.2

Steps to reproduce (*)

  1. Add e.g. 10 products (more than "Result limit" from point 2.) to Magento store, which meet the specified Related/Cross-Sell/Up-Sell "Products to Display" conditions.
  2. Set "Result limit" for rule e.g. on 2.
  3. Search a product which meets the "Product to Match" conditions
  4. Check the Related/Cross-Sell/Up-Sell products

Expected result (*)

  1. I get different products for each searching.

Actual result (*)

  1. I always get the same two products. There are the products with the lowest IDs, which meet rule conditions.
  2. It does not matter how much products from database meet the rule conditions.
  3. It is caused by SQL query to get products from database for specified rule.
  4. Always the same two products are returned from database. Result from database should be randomized.

Maximum "Result limit" is 20 and it is fine for performance, but currently, if we have e.g. 50 products which meet the rule conditions, only first 20 products with the lowest IDs will be displayed to customer and it is not good from business perspective.
Results should be randomized on database query level.


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Mar 16, 2021

Hi @mtwegrzycki. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mtwegrzycki
Copy link
Contributor Author

@magento I am working on this

@mtwegrzycki mtwegrzycki removed their assignment Mar 19, 2021
@engcom-Oscar engcom-Oscar self-assigned this Mar 19, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2021

Hi @engcom-Oscar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Oscar engcom-Oscar added Component: Catalog Component: Rule Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 19, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Mar 19, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-41444 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@gabrieldagama gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 20, 2021
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Apr 20, 2021
@Kiraberos
Copy link
Contributor

@magento I am working on this

@Kiraberos
Copy link
Contributor

@mtwegrzycki I want to clarify:
What did you mean about 'Set "Result limit" for rule e.g. on 2.'?
In the admin panel we didn't set result limits for related, upsell and cross-sell.
According to the project, I can't find a use for this condition 'related-rule'.
image

In Magento/Catalog/view/frontend/templates/product/list/items.phtml I see that such conditions exist, but it looks like there should be an appropriate functionality for these conditions.
There is a $shuffle variable to which the value from the function is assigned isShuffled().This functionality should solve this problem.
image
But this functionality is in the commercial version. The module is responsible for it Magento_TargetRule.
And thanks to this functionality we can randomize the result for related, upsell and cross-sell products.

Therefore, perhaps you should reconsider this pr and the task.

@Kiraberos Kiraberos removed their assignment Dec 22, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Catalog Component: Catalog Component: Rule Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
  
Ready for Development
Development

No branches or pull requests

6 participants