Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Fix missing video when advanced js bundling used #32501

Closed
4 tasks
m2-assistant bot opened this issue Mar 16, 2021 · 5 comments · Fixed by #32499
Closed
4 tasks

[Issue] Fix missing video when advanced js bundling used #32501

m2-assistant bot opened this issue Mar 16, 2021 · 5 comments · Fixed by #32499
Assignees
Labels
Component: ProductVideo Event: Adobe Summit Hackathon Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Mar 16, 2021

This issue is automatically created based on existing pull request: #32499: Fix missing video when advanced js bundling used


Description (*)

This PR fixes issue when a video is missing in the product gallery when advanced JS bundling is enabled and used.

This happened because the event gallery:loaded was already triggered before this code was executed.

In order to fix the issue I looked how with this event we working in different places, so I did same in this piece of code as well.

gallery.data('gallery') ?
this._onGalleryLoaded(gallery) :
gallery.on('gallery:loaded', this._onGalleryLoaded.bind(this, gallery));

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Configure advanced JS bundling, I used this one https://github.com/magesuite/magepack
  2. Go to a product page that contains youtube or vimeo video
  3. See gallery, try to find the video

Actual result: (before this PR)
❌ No video appeared, just image shown

Expected result: (after this PR)
✔ Video should appear in gallery

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: ProductVideo Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Mar 16, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Mar 16, 2021
@pemann
Copy link

pemann commented Mar 17, 2021

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @pemann. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@gabrieldagama gabrieldagama added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 26, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @gabrieldagama
Thank you for verifying the issue. Based on the provided information internal tickets MC-42059 were created

Issue Available: @gabrieldagama, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@gabrieldagama
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #32499 by @ihor-sviziev in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

@gabrieldagama gabrieldagama added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Apr 26, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ProductVideo Event: Adobe Summit Hackathon Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

4 participants