-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MFTF] Eliminate AspectMock from AllureHelperTest (Complex!) #33294
Comments
Hi @sivaschenko. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento I am working on this |
@magento export issue to Jira project AC as Story |
✅ Jira issue https://jira.corp.magento.com/browse/AC-315 is successfully created for this GitHub issue. |
PR has been merged to MFTF repo |
This task is tricky and requires investigation on the approach to mock static calls without Aspect Mock
Goal
codeception/aspect-mock
library is still not compatible with PHP 8.0 at the time of the creation of this ticket.To speed up Magento compatibility with new PHP versions we'd like to eliminate
codeception/aspect-mock
dependency from MFTF. This will make MFTF compatible with PHP 8.0 that is required for declaring the Magento core PHP 8 compatible as well.In order to do this existing unit tests using AspectMock should be refactored to use PHPUnit instead.
Task
Eliminate AspectMock usage from
dev/tests/unit/Magento/FunctionalTestFramework/Allure/AllureHelperTest.php
in https://github.com/magento/magento2-functional-testing-framework repository.Example
Mocking an object using AspectMock (current):
Mocking an object using PHPUnit (refactored code):
Example pull request: magento/magento2-functional-testing-framework#833
The text was updated successfully, but these errors were encountered: