Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Vimeo video play issue after clicking play icon #33417

Open
5 tasks
m2-assistant bot opened this issue Jul 5, 2021 · 22 comments · May be fixed by #33407
Open
5 tasks

[Issue] Vimeo video play issue after clicking play icon #33417

m2-assistant bot opened this issue Jul 5, 2021 · 22 comments · May be fixed by #33407
Assignees
@engcom-Delta
Labels
Area: UI Framework Component: ProductVideo Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jul 5, 2021

This issue is automatically created based on existing pull request: #33407: Vimeo video play issue after clicking play icon

Description (*)

Vimeo video does't play video after clicking play button on video thumbnail of product page. Instead it shows another play icon in iframe.
It needs 3 clicks to play a vimeo video.
1 - Click on Video icon on left panel.
2 - Click play icon on thumbnail.
3 - Then Click on another play icon.

Expected Result:
It plays vimeo video when we click on play button.

Advance browsers like FireFox, Chrome and Safari are now blocking video autoplay by default. Chrome auto play policy https://developers.google.com/web/updates/2017/09/autoplay-policy-changes.

To fix this issue i added muted=1 in iframe url. After adding muted=1 it plays video by clicking play icon one time.

Related Pull Requests

Manual testing scenarios (*)

  1. ... Open product page.
  2. ... Select video from gallary.
  3. ... Click on play button.
  4. ... It plays vimeo video.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot linked a pull request Jul 5, 2021 that will close this issue
Open
6 tasks
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Jul 5, 2021
@engcom-Delta engcom-Delta self-assigned this Jul 5, 2021
@m2-assistant
Copy link
Author

m2-assistant bot commented Jul 5, 2021

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

Hi,

I tried to reproduce the issue on Magento 2.4 Develop, able to play the video .Please find attached snapshot for reference.
Kindly let us know if any specific scenario this happens. Hence added label 'Needs update
vimeo_video
'

@engcom-Delta engcom-Delta added the Issue: needs update Additional information is require, waiting for response label Jul 5, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Jul 5, 2021
@ashar01
Copy link

ashar01 commented Jul 7, 2021

@engcom-Delta
Have to try to reproduce this issue on frontend ?

@m2-community-project m2-community-project bot moved this from Needs Update to Ready for Confirmation in Issue Confirmation and Triage Board Jul 14, 2021
@m2-community-project m2-community-project bot removed the Issue: needs update Additional information is require, waiting for response label Jul 14, 2021
@engcom-Delta
Copy link
Contributor

Hi @ashar01,

Yes, it also tested from Frontend, it works as expected.
Please find attached video for reference.

https://r5---sn-npoe7ned.c.chat.google.com/videoplayback?expire=1626282141&ei=be7uYMqLLeLAn88P55Ga8Ak&ip=27.59.179.162&id=4cd3a921146052db&itag=18&source=hangouts_chat&requiressl=yes&sc=yes&susc=hc&mime=video/mp4&vprv=1&dur=20.085&lmt=1626271282750452&txp=0011224&sparams=expire,ei,ip,id,itag,source,requiressl,susc,mime,vprv,dur,lmt&sig=AOq0QJ8wRQIhALQn1BeU37iZSZ1A_ekDGyN6uKqyFvEZYSMCgfRcaBfOAiB9zu1PQRjx-BE_7ySaraWxwsyF4XPxT1OFZcrK7_oqMg%3D%3D&redirect_counter=1&cm2rm=sn-h55ee76&req_id=cfb917f27862a3ee&cms_redirect=yes&mh=QY&mm=34&mn=sn-npoe7ned&ms=ltu&mt=1626271245&mv=m&mvi=5&pl=22&lsparams=mh,mm,mn,ms,mv,mvi,pl,sc&lsig=AG3C_xAwRgIhAIshssakZz4-EultkZtR4wlygVXxjLswHfTAqsctn9cMAiEAj6C6zVKcJbSQnUDApqebbuVdMQvioVNbtTmNiFt00Qo%3D

Hence added the label 'Needs Update'.

Thanks

@engcom-Delta engcom-Delta added the Issue: needs update Additional information is require, waiting for response label Jul 14, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Jul 14, 2021
@engcom-Delta
Copy link
Contributor

There has no update from reporter .It has been more than 14 days. Hence closing the issue.
Kindly log new issue if required or re-open the existing issue.

Thanks

@engcom-Alfa engcom-Alfa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 26, 2021
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Nov 2, 2021 •
edited

Thanks for retrying to reproduce the issue @engcom-Delta .
The issue is reproducible with Microsoft Edge only, with the version number 95.0
Navigate to Admin > Product >Images and Videos > Thumbnail.
Click on the video clip in-between of it. (Not on the play icon of the video).
Issue: First time, if we click, video doesn't play. After re clicking again, video plays well.

This issue is not identified in other browsers.
Hence re-opening the issue!

@engcom-Alfa engcom-Alfa reopened this Nov 2, 2021
@m2-community-project m2-community-project bot removed Progress: done Issue: needs update Additional information is require, waiting for response labels Nov 2, 2021
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in High Priority Backlog Nov 2, 2021
@engcom-Alfa engcom-Alfa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Progress: ready for dev labels Nov 2, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 2, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 2, 2021
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Nov 2, 2021
@engcom-Alfa engcom-Alfa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Nov 2, 2021
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-1612 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Nov 2, 2021

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ashar01
Copy link

ashar01 commented Nov 12, 2021

@magento give me test instance

@magento-deployment-service
Copy link

Hi @ashar01. Thank you for your request. Comments like @magento give me test instance are intended for instance deployments on Pull Requests. Please use comment like: @magento give me 2.4-develop instance to request an instance on an issue.

@ashar01
Copy link

ashar01 commented Nov 12, 2021

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @ashar01. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @ashar01, here is your Magento Instance: https://15bae4747efa6d16f65c631981203542-2-4-develop.instances.magento-community.engineering
Admin access: https://15bae4747efa6d16f65c631981203542-2-4-develop.instances.magento-community.engineering/admin_fdf7
Login: cc96a9b3
Password: 3bbe4cf6e91d

@ashar01
Copy link

ashar01 commented Dec 14, 2021

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @ashar01. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @ashar01, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@ashar01
Copy link

ashar01 commented Dec 14, 2021

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @ashar01. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @ashar01, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@ashar01
Copy link

ashar01 commented Jan 21, 2022

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @ashar01. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @ashar01, here is your Magento Instance: https://dca1448b22b95d57c8fcea537fd7966a.instances.magento-community.engineering
Admin access: https://dca1448b22b95d57c8fcea537fd7966a.instances.magento-community.engineering/admin_1f14
Login: 5b6a721b
Password: dc33baccd6f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engcom-Delta engcom-Delta

Labels
Area: UI Framework Component: ProductVideo Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
  
Pull Request In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vimeo video play issue after clicking play icon ashar01/magento2
5 participants
@ihor-sviziev @ashar01 @engcom-Alfa @engcom-Delta @github-jira-sync-bot