Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm packages to the latest versions #33512

Closed
sivaschenko opened this issue Jul 16, 2021 · 4 comments
Closed

Update npm packages to the latest versions #33512

sivaschenko opened this issue Jul 16, 2021 · 4 comments
Assignees
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: Platform Health Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Jul 16, 2021

Update npm packages to the latest versions

The following npm packages should be updated:

  • grunt
  • grunt-contrib-clean
  • grunt-contrib-connect
  • grunt-contrib-cssmin
  • grunt-contrib-imagemin
  • grunt-contrib-less
  • grunt-eslint
  • imagemin-svgo
  • morgan
  • path
  • serve-static
  • squirejs
  • strip-json-comments
  • time-grunt
  • underscore

Conclusion

  • glob from ~7.1.1 to ~7.1.7 (latest)
  • grunt from ~1.0.1 to ~1.4.1 (latest)
  • grunt-contrib-clean from ~1.1.0 to ~2.0.0 (latest)
  • grunt-contrib-connect from ~1.0.2 to ~3.0.0 (latest)
  • grunt-contrib-less (not latest. Details below)
  • grunt-contrib-cssmin from ~2.2.1 to ~4.0.0 (latest)
  • grunt-contrib-jasmine (not latest. Details below)
  • grunt-contrib-imagemin from ~2.0.1 to ~4.0.0 (latest)
  • grunt-contrib-watch from ~1.0.0 to ~1.1.0 (latest)
  • grunt-eslint from ~20.1.0 to ~20.2 .0(not latest. Details below)
  • grunt-replace from ~1.0.1 to ~2.0.2 (latest)
  • load-grunt-config from ~0.19.2 to ~4.0.1 (latest)
  • imagemin-svgo from ~5.2.1 to ~7.1.0(not latest. Details below)
  • morgan from ~1.9.0 to ~1.10.0 (latest)
  • node-minify from ~2.3.1 to ~3.6.0 (latest)
  • path - probably abandoned
  • serve-static from ~1.13.1 to ~1.14.1 (latest)
  • squirejs - probably abandoned
  • strip-json-comments from ~2.0.1 to ~3.1.1 (not latest. Details below)
  • time-grunt from ~1.4.0 to ~2.0.0 (latest)

  • grunt-contrib-jasmine - from the next 2.0.0, the library has switched from PhantomJS to Chrome Headless via puppeteer, and requires reconfiguring the extension.
  • grunt-contrib-less - version 3.0.0 and higher, are failing on Github builds without an explicitly reason
  • grunt-eslint - from the next 21.0.0 we're started getting the Warning: must provide pattern
  • imagemin-svgo - version 8.0.0 and higher, are failing on Github builds without an explicitly reason
  • strip-json-comments - versions above 3.1.1 throw the following warning: require() of ES modules is not supported.

⚠️ Deprecated npm packages

❓ Broken or unavailable builds on https://www.npmjs.com/

  • grunt-banner
  • grunt-contrib-watch
  • grunt-text-replace
@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Platform Health labels Jul 16, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sivaschenko
Copy link
Member Author

@magento export issue to Jira project AC as Story

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-354 is successfully created for this GitHub issue.

@mrtuvn mrtuvn self-assigned this Jul 17, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 17, 2021

Hi @mrtuvn. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in Platform Health Backlog Jul 17, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in Platform Health Backlog Jul 17, 2021
@andrewbess andrewbess moved this from Pull Request In Progress to Dev In Progress in Platform Health Backlog Aug 25, 2021
@m2-community-project m2-community-project bot added Progress: dev in progress Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Progress: PR in progress labels Aug 25, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in Platform Health Backlog Aug 31, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Platform Health Backlog Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: Platform Health Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
No open projects
Development

No branches or pull requests

3 participants