-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating symfony/console causing setup:di:compile failure #33595
Comments
Hi @Skyfly2021. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
it |
Please downgrade the package, finally solved: |
i created a pull request for symfony/console: symfony/symfony#42281 and also any 2.3.x magento2 version is affected. the problem are the missing php-doc parameters which are checked by the magento2 compiler |
+1 |
Thanks @brosenberger & @Skyfly2021! @Skyfly2021: I don't have issues with It would be great if Magento's Issue will happen for Magento 2.3.5 and higher versions (Magento 2.3.4 restricted |
If you want to patch the issue instead of pinning symfony/console's version:
|
Ran into this aswell. Luckily it is a minor patch to add, but hopefully it will be corrected in Symfony. |
It's not a symfony issue, it's Magento not being smart enough to resolve types correctly :) Workaround: |
I don't think that not allowing versions higher then or equal to 4.4.27 to be installed is the correct workaround. You tend to forget about these workarounds and if symfony then releases a newer version that fixes a security issue, you'll not get it. It's probably better to only conflict with version 4.4.27 and still allow higher versions. And then if it turns out that the next version still has the same problem, add that version to the conflict range. It looks like they are considering reverting the change in the next version v4.4 of |
@hostep workaround is temporary fix, also the issue is not on the Symfony side, but Magento, as it was for the "Laminas issue" :) |
The changes will be reverted in symfony/console:4.4.29 |
There is a pull request for symfony/console. This will fix that issue. |
The issue exists within Magento. The change made in |
THIS: 2.composer require symfony/console:4.4.26 did the trick for me Thank you! |
There is fix for the 4.4 version in Symfony/console, which isn't tagged yet. See symfony/symfony#42281 (comment) for details. This should still be fixed for the long term though. |
Hi, I just did a short investigation - it looks like this issue is coming from the Laminas Code component.
while $parameter->detectType() is following:https://github.com/laminas/laminas-code/blob/3.4.1/src/Reflection/ParameterReflection.php#L77-L113 For the And, in the latest laminas-code, this issue isn't resolved yet as well. |
Note: symfony/console has released a new version 4.4.29 as a hotfix for Magento where were resolved this issue. Now you can run Note: this is not a permanent fix, we still should fix the root cause of this. |
FYI I prepared PR to the laminas-code to fix the listed issue. |
Hi @ihor-sviziev. Thank you for working on this issue.
|
Finally, the PR laminas/laminas-code#95 that fixes incorrect return type detecting was just merged and released in https://github.com/laminas/laminas-code/releases/tag/4.4.3! |
Preconditions (*)
1.2.4.2-p1
2.Centos 8
3.php 7.4
Steps to reproduce (*)
Expected result (*)
Actual result (*)
2.Incompatible argument type: Required type: int. Actual type: string
The name of the upgrade package is not remembered
The following error occurred during compilation
Workaround
The
symfony/console
released version 4.4.29 as a hotfix for Magento issue.For now, you can run
composer update symfony/console
Note: the root cause of this issue still not resolved yet
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.
The text was updated successfully, but these errors were encountered: