Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Customer Newsletter Subscriptions are inconsistent in multi website setups #33599

Closed
1 of 5 tasks
pawel-siejba opened this issue Jul 27, 2021 · 4 comments
Closed
1 of 5 tasks
Assignees
Labels
Area: APIs Component: CustomerGraphQl Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: GraphQL Reported on 2.4.2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.

Comments

@pawel-siejba
Copy link
Contributor

pawel-siejba commented Jul 27, 2021

Customer type is_subscribed field value is taken from the customer website: https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/CustomerGraphQl/Model/Resolver/IsSubscribed.php#L52

When you're updating the subscription via createCustomer/createCustomerV2/updateCustomer/updateCustomerV2 mutation the subscription store is taken from the current store: https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/CustomerGraphQl/Model/Customer/UpdateCustomerAccount.php#L115

Preconditions (*)

  1. Magento version 2.4.2(probably more)
  2. At least 2 websites
  3. Customer Global accounts enabled

Steps to reproduce (*)

  1. Create customer account in the 1st website
  2. Subscribe to newsletter from the 2nd website
  3. Confirm your subscription

Expected result (*)

  1. Customer can see that he's subscribed

Actual result (*)

  1. Customer can't see that he's subscribed as the subscription data is taken from the website he created his account in, but the subscription is created for the website/store he was browsing from when updating the subscription.

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jul 27, 2021

Hi @pawel-siejba. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Jul 27, 2021
@Den4ik Den4ik added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Aug 6, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Aug 6, 2021
@Den4ik Den4ik added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Aug 6, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @Den4ik
Thank you for verifying the issue. Based on the provided information internal tickets MC-43013 were created

Issue Available: @Den4ik, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Reported on 2.4.2 Indicates original Magento version for the Issue report. label Aug 10, 2021
@sdzhepa sdzhepa added the Priority: P3 May be fixed according to the position in the backlog. label Aug 12, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Aug 12, 2021
@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Aug 20, 2021

Verified the issue on Magento 2.4-develop branch and the issue is reproducible.

Preconditions (*)

  1. At least 2 websites setup
    https://devdocs.magento.com/guides/v2.4/config-guide/multi-site/ms_websites.html
  2. Customer Global accounts enabled
    https://docs.magento.com/user-guide/customers/account-scope.html

Steps To Reproduce

  1. Create customer account in the 1st website

  2. Sign in to 2nd website using same credentials

  3. Subscribe to newsletter from the 2nd website

  4. Confirm your subscription

  5. Subscription can be seen in 2nd website

  6. Go to 1st website MyAccount->NewsLetter Subscription. Subscription is not shown

@cpartica cpartica added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. and removed Priority: P3 May be fixed according to the position in the backlog. labels Apr 8, 2022
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Apr 8, 2022
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in Low Priority Backlog Apr 8, 2022
@cpartica cpartica added Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Area: APIs Project: GraphQL Component: CustomerGraphQl and removed Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Apr 8, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Apr 8, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Apr 8, 2022
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Apr 19, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in High Priority Backlog Apr 20, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Apr 20, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in High Priority Backlog May 9, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog May 9, 2022
@engcom-Alfa
Copy link
Contributor

Hello @pawel-siejba
As I can see this issue got fixed in the scope of the internal Jira ticket AC-2797 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-2797&type=commits

Based on Jira, target version is 2.4.5

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: APIs Component: CustomerGraphQl Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: GraphQL Reported on 2.4.2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Development

Successfully merging a pull request may close this issue.

9 participants