Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie acceptance still displays message in header #33811

Closed
5 tasks
devchris79 opened this issue Aug 16, 2021 · 14 comments
Closed
5 tasks

Cookie acceptance still displays message in header #33811

devchris79 opened this issue Aug 16, 2021 · 14 comments

Comments

@devchris79
Copy link

Preconditions (*)

  1. Magento 2.4.3

Steps to reproduce (*)

  1. Switch on cookie restriction mode, settings as below:
    image

Expected result (*)

  1. Message for cookies acceptance presented, upon acceptance all messages should be removed.

Actual result (*)

  1. At the top of our site we see a message "The store will not work correctly in the case when cookies are disabled." that disappeared after acceptance in version 2.4.2.

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Aug 16, 2021

Hi @devchris79. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@chrisastley
Copy link

I have the same issue although Cookie Restriction Mode has always been disabled, but after updating from 2.4.2-p1 to 2.4.3 I have the 'The store will not work correctly in the case when cookies are disabled.' message showing although cookies/sessions are working fine.

@ajijshekh123 ajijshekh123 self-assigned this Aug 16, 2021
@m2-assistant
Copy link

m2-assistant bot commented Aug 16, 2021

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo self-assigned this Aug 16, 2021
@m2-assistant
Copy link

m2-assistant bot commented Aug 16, 2021

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@mrtuvn
Copy link
Contributor

mrtuvn commented Aug 16, 2021

Can you share screenshot and record maybe make easier to QC team can check ? I don't see any messages cookie at the top

@mrtuvn
Copy link
Contributor

mrtuvn commented Aug 16, 2021

cookie

@devchris79
Copy link
Author

image

@devchris79
Copy link
Author

I think this commit has probably broken it: MC-41474

@mrtuvn
Copy link
Contributor

mrtuvn commented Aug 16, 2021

i think your case may similar #33796
but i don't know how to reproduce at the clean install 2.4.3

@chrisastley
Copy link

@devchris79 I notice you are using the Porto theme, both sites I have the issue on are also using Porto. Not sure if it's related though.

@mrtuvn
Copy link
Contributor

mrtuvn commented Aug 16, 2021

Have you check what theme that use template cookie status ? Maybe that template override current magento template. That make that block always show
I will assume somehow that theme still use old version with class/id name cookie-status but in latest version magento change class to cookie-status-message. So your old block will still visible

@chrisastley
Copy link

Have you check what theme that use template cookie status ? Maybe that template override current magento template. That make that block always show
I will assume somehow that theme still use old version with class name cookie-status but in latest version magento change class to cookie-status-message. So your old block will still visible

On a site running version 2.4.2-p1 I can see this in the source.

<script type="text/javascript">document.querySelector("#cookie-status").style.display="none";</script>

But it isn't in the source code of 2.4.3, when I look at the changes introduced in #33796 there is an added css/less rule in the base theme Magento_Theme/web/css/source/_module.less

The Porto theme has it's own Magento_Theme/web/css/source/_module.less file without this rule so I'm guessing this is the issue as the base one won't be loaded?

@devchris79
Copy link
Author

OK, I have fixed this now. It appears that any theme now needs to turn the message off due to MC-41474. Porto doesn't make any attempt so its always displayed.

You need to add app/design/frontend/Smartwave/porto/Magento_Theme/web/css/source/_module.less:

.cookie-status-message {
display: none;
}

I put this on line 234 for Porto

@devchris79
Copy link
Author

The message shouldn't have changed to default on though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants