-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie acceptance still displays message in header #33811
Comments
Hi @devchris79. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
I have the same issue although Cookie Restriction Mode has always been disabled, but after updating from 2.4.2-p1 to 2.4.3 I have the 'The store will not work correctly in the case when cookies are disabled.' message showing although cookies/sessions are working fine. |
Hi @ajijshekh123. Thank you for working on this issue.
|
Hi @engcom-Bravo. Thank you for working on this issue.
|
Can you share screenshot and record maybe make easier to QC team can check ? I don't see any messages cookie at the top |
I think this commit has probably broken it: MC-41474 |
i think your case may similar #33796 |
@devchris79 I notice you are using the Porto theme, both sites I have the issue on are also using Porto. Not sure if it's related though. |
Have you check what theme that use template cookie status ? Maybe that template override current magento template. That make that block always show |
On a site running version 2.4.2-p1 I can see this in the source. <script type="text/javascript">document.querySelector("#cookie-status").style.display="none";</script>But it isn't in the source code of 2.4.3, when I look at the changes introduced in #33796 there is an added css/less rule in the base theme Magento_Theme/web/css/source/_module.less The Porto theme has it's own Magento_Theme/web/css/source/_module.less file without this rule so I'm guessing this is the issue as the base one won't be loaded? |
OK, I have fixed this now. It appears that any theme now needs to turn the message off due to MC-41474. Porto doesn't make any attempt so its always displayed. You need to add app/design/frontend/Smartwave/porto/Magento_Theme/web/css/source/_module.less: .cookie-status-message { I put this on line 234 for Porto |
The message shouldn't have changed to default on though... |
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.
The text was updated successfully, but these errors were encountered: