[GraphQl 2.4.2] subtotal_with_discount_excluding_tax is calculated using discount including tax

[Hexmage]

Preconditions (*)

1. Magento 2.4.2
2. tax/calculation/price_includes_tax = including tax
3. tax/calculation/apply_after_discount = after discount
4. tax/calculation/discount_tax = including tax

Steps to reproduce (*)

1. Create a cart and add a product that's worth 1000 (incl tax) with a tax% of 25%.
2. Set a discount on the cart for 10.
3. Do the following graphql request

query getCartDetails($cartId: String!) {
	cart(cart_id: $cartId) {
                 prices {
			applied_taxes {
				amount {
					value
				}
			}
			discount {
				amount {
					value
				}
			}
			subtotal_including_tax {
				value
			}
			subtotal_excluding_tax {
				value
			}
                        subtotal_with_discount_excluding_tax {
				value
			}
			grand_total {
				value			
                        }
		}
	}
}

Expected result (*)

{
    "data": {
        "cart": {
            "prices": {
                "applied_taxes": [
                    {
                        "amount": {
                            "value": 198
                        }
                    }
                ],
                "discount": {
                    "amount": {
                        "value": -10
                    }
                },
                "subtotal_including_tax": {
                    "value": 1000
                },
                "subtotal_excluding_tax": {
                    "value": 800
                },
                "subtotal_with_discount_excluding_tax": {
                    "value": 792
                },
                "grand_total": {
                    "value": 990
                }
            }
        }
    }
}

"subtotal_with_discount_excluding_tax" should be 1000 - 10 - 198 = 792
Which is same as 800 (Sub total) - 8 (Sub total discount) = 792

Actual result (*)

{
    "data": {
        "cart": {
            "prices": {
                "applied_taxes": [
                    {
                        "amount": {
                            "value": 198
                        }
                    }
                ],
                "discount": {
                    "amount": {
                        "value": -10
                    }
                },
                "subtotal_including_tax": {
                    "value": 1000
                },
                "subtotal_excluding_tax": {
                    "value": 800
                },
                "subtotal_with_discount_excluding_tax": {
                    "value": 790
                },
                "grand_total": {
                    "value": 990
                }
            }
        }
    }
}

UI Issue: Payment Breakup details sum is not matching with Grand Total.
800 - 10 + 198 = 988 but not 990

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Hexmage. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Verified the issue on Magento2.4-develop branch and the issue is reproducible on both Frontend and GraphQl response as well:
Steps performed:
Stores - Settings - Configuration - Sales - Tax - Set Catalog Prices - Including Tax
Apply Discount On Prices - Including Tax
Apply Customer Tax - After Discount and Save
Create a cart and add a product that's worth 1000 (incl tax) with a tax% of 25%.
Set a discount on the cart for $10 fixed amount for whole Cart.
Run "GetCartDetails" GraphQL request:
Issue: Response: "subtotal_with_discount_excluding_tax" is updated as subtotal - discount - total tax without discount
UI Issue: Payment Breakup details sum is not matching with Grand Total.
800 - 10 + 198 = 988 but not 990
Expected behavior:
"subtotal_with_discount_excluding_tax" should be updated as subtotal - discount - total tax with discount

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-1084 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[m2-assistant]

Hi @cpartica. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
• 2. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

Hello @Hexmage,
Thanks for reporting the issue!

The issue has been fixed and delivered by the internal team. Related commits can be found here.

Thanks