Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price not depends from website scope when base price updating via REST api #33915

Open
1 of 5 tasks
monteshot opened this issue Aug 26, 2021 · 15 comments
Open
1 of 5 tasks
Assignees
Labels
Area: Pricing Component: Pricing Component: Store Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@monteshot
Copy link
Contributor

monteshot commented Aug 26, 2021

Preconditions (*)

  1. Magento 2.4.2-p1
  2. Get Admin token before using base price endpoint

Steps to reproduce (*)

  1. Set REST endpoint using code for example https://aquapolis-migua.dev.perspective.net.ua.local/rest/ru/V1/products/base-prices where '/ru/' - code
    2.Put Data in body for example
    { "prices": [ { "price": 14, "store_id": 2, "sku": "99999", "extension_attributes": {} } ] }

Expected result (*)

  1. Base price should use settings from website scope

Actual result (*)

price_bug.mp4
  1. Base price setting gets data from storeview

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2021

Hi @monteshot. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2021

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Echo
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Echo. Thank you for your request. I'm working on Magento instance for you.

@engcom-Echo
Copy link
Contributor

Hi @monteshot
Thanks for reporting this issue.
I tried to reproduce this issue, using the video you have attached, unfortunately it was a little confusing for me. Could you please help me out with the Steps that you are performing to reproduce the issue & explain to me little more about the issue.
I could also share with you the steps I did,

  1. On a clean instance of magento 2.4-develop branch , created a multi store view set up(say Russian storeview & Netherland store view)
  2. Got the Admin token & Hit the API to add/update product prices rest/V1/products/base-prices with the payload
    { "prices": [ { "price": 122, "store_id": 3, "sku": "24-MB01" } ] }
    here store Id 3 corresponds to the Netherlandian Store View & after hitting the API , the Base Price on the corresponding store view got updated.
    So please provide more details or additional/missing steps regarding the same.

Thank you.

@engcom-Echo engcom-Echo added Issue: needs update Additional information is require, waiting for response and removed Issue: ready for confirmation labels Aug 26, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Aug 26, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Aug 26, 2021
@monteshot
Copy link
Contributor Author

Hi @monteshot
Thanks for reporting this issue.
I tried to reproduce this issue, using the video you have attached, unfortunately it was a little confusing for me. Could you please help me out with the Steps that you are performing to reproduce the issue & explain to me little more about the issue.
I could also share with you the steps I did,

  1. On a clean instance of magento 2.4-develop branch , created a multi store view set up(say Russian storeview & Netherland store view)
  2. Got the Admin token & Hit the API to add/update product prices rest/V1/products/base-prices with the payload
    { "prices": [ { "price": 122, "store_id": 3, "sku": "24-MB01" } ] }
    here store Id 3 corresponds to the Netherlandian Store View & after hitting the API , the Base Price on the corresponding store view got updated.
    So please provide more details or additional/missing steps regarding the same.

Thank you.

@engcom-Echo

Hello.
Let me clarify steps.
You hit the Netherlands StoreView with code (for example) "ne" and in payload you has put
{ "prices": [ { "price": 122, "store_id": 3, "sku": "24-MB01" } ] }
Then please try to hit API with with code "ne" and the with Russian store_id (for ex: "2") in payload
{ "prices": [ { "price": 123, "store_id": 2, "sku": "24-MB01" } ] }

The price will change. Moreover the price on RU and NE StoreView will be different on product page and the same on the catalogsearch

Thank you.

@engcom-Echo
Copy link
Contributor

engcom-Echo commented Aug 26, 2021

Hi @monteshot
I tried to hit API with with code "nl" ( for Netherland storeview) and the with Russian store_id (for ex: "2") in payload
{ "prices": [ { "price": 123, "store_id": 2, "sku": "24-MB01" } ] }
I got the Russian store view price updated. It seems the store code passed via the url is ignored & the one passed via the payload is taken into consideration. Do you concur with this scenario?

@monteshot
Copy link
Contributor Author

@engcom-Echo Totally agreed

@engcom-Echo
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Echo. Thank you for your request. I'm working on Magento instance for you.

@engcom-Echo
Copy link
Contributor

This issue is reproducible on 2.4-develop branch.
Steps to reproduce.

  1. On a clean instance of magento 2.4-develop branch , created a multi store view set up(say, Russian store view (ru - store_id=2 & Netherland store view (nl - store_id=3))
  2. Get the Admin token & Hit the API to add/update product prices rest/ru/V1/products/base-prices with the payload
    { "prices": [ { "price": 122, "store_id": 3, "sku": "24-MB01" } ] }
    here we are passing the scope as ru (Russian store view) & store_id as 3 corresponding to the Netherland store view & after hitting the API , the Base Price of Netherland store view got updated.
    Observed that the store code passed via the url is ignored & the one passed via the payload is taken into consideration.

@engcom-Echo engcom-Echo added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Issue: needs update Additional information is require, waiting for response labels Aug 26, 2021
@m2-community-project m2-community-project bot moved this from Needs Update to Ready for Confirmation in Issue Confirmation and Triage Board Aug 26, 2021
@engcom-Echo engcom-Echo added Severity: S1 Affects critical data or functionality and forces users to employ a workaround. and removed Issue: ready for confirmation labels Aug 26, 2021
@engcom-Echo engcom-Echo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Aug 26, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Aug 26, 2021
@engcom-Echo engcom-Echo removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Area: Pricing labels Aug 26, 2021
@m2-community-project m2-community-project bot moved this from Confirmed to Ready for Confirmation in Issue Confirmation and Triage Board Aug 26, 2021
@engcom-Echo engcom-Echo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Aug 26, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Aug 26, 2021
@engcom-Alfa engcom-Alfa added the Priority: P3 May be fixed according to the position in the backlog. label Aug 31, 2021
@m2-community-project m2-community-project bot added this to Dev In Progress in Low Priority Backlog Aug 31, 2021
@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 9, 2021
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-1188 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Sep 9, 2021

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Pricing Component: Pricing Component: Store Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Low Priority Backlog
  
Dev In Progress
Development

No branches or pull requests

5 participants