[GraphQl 2.4.2] All active payment methods are returned for "free" orders

[Hexmage]

Preconditions (*)

1. Magento 2.4.2
2. Enable zero subtotal checkout
3. Enable Check / Money order

Steps to reproduce (*)

1. Create a product with price 0
2. Add free product to cart
3. Set a shipping and billing address
4. Set freeshipping_freeshipping shipping method.
5. Run graphql query:

query getCartDetails($cartId: String!) {
	cart(cart_id: $cartId) {
	    available_payment_methods {
                code
                title
            }
    }
}

Expected result (*)

{
    "data": {
        "getCartDetails": {
            "cart": {
                "available_payment_methods": [
                    {
                        "code": "free",
                        "title": "No Payment Information Required"
                    }
                ],
            }
        }
    }
}

Actual result (*)

{
    "data": {
        "getCartDetails": {
            "cart": {
                "available_payment_methods": [
                    {
                        "code": "free",
                        "title": "No Payment Information Required"
                    },
                   {
                        "code": "checkmo",
                        "title": "Check / Money order"
                    },
                ]
            }
        }
    }
}

The Issue

If the order is free most other payment methods will break when trying to place the order. In the normal magento frontend this is handle by hiding all the other payment methods with javascript. Imo the other payment methods shouldn't be returned in the first place if they aren't going to work.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Hexmage. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Verified the issue on Magento 2.4-develop branch and the issue is reproducible:
Steps to reproduce:
Stores - Configuration - Sales - Payment Methods - Enable zero subtotal checkout
Enable Check / Money order
Create a product with price 0
Enable Free Shipping from Stores - Configuration - Sales - Delivery Methods
Reindex and clear cache
Generate Customer token using GraphQL request
Get Cart ID of the logged in Customer using GraphQL request
{ customerCart { id items { id product { name sku } quantity } } }
Add Free Product to Cart using GraphQL or from front-end using above customer
mutation { addProductsToCart( cartId: "V08ldamy2bjY7FQH1vCnQfZ3wOaXO2to" cartItems: [ { quantity: 1 sku: "Test Productsssss" } ] ) { cart { items { product { name sku } quantity } } } }
Set Shipping Address and Billing address
Set Free-shipping Method using GraphQL:
mutation { setShippingMethodsOnCart( input: { cart_id: "V08ldamy2bjY7FQH1vCnQfZ3wOaXO2to", shipping_methods: [ { carrier_code: "freeshipping" method_code: "freeshipping" } ] } ) { cart { shipping_addresses { selected_shipping_method { carrier_code carrier_title method_code method_title amount { value currency } } } } } }

Run the GraphQL query
{ cart(cart_id: "V08ldamy2bjY7FQH1vCnQfZ3wOaXO2to") { available_payment_methods { code title } } }
Issue: All payment methods are getting displayed in GraphQL response

Expected behavior: All other payment methods should not be displayed. There is no issue on front end - Only one payment method is displayed to the user:

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-1195 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[Hexmage]

In the frontend the hiding of the other payment methods is done by javascript in the checkout. I assume it's done because the other payment methods do not know if the free payment method is available. In my opinion the best solution would be to move this logic from the javascript to the php code. Because the free payment method is only available when all the other payment methods should be hidden.

[ciprianmariuta]

@magento I'm working on it

[cpartica]

this issue is being worked on internally for 2.4.5

[engcom-Alfa]

Hi @Hexmage ,
Thanks for your reported bug, the internal team has fixed and delivered this issue successfully.
Please find related commits HERE.

Kindly upgrade to the latest Magento version 2.4-develop to retest the case.

In case of any Magento related issues found in 2.4-develop, you may report a new bug with all the information like Preconditions, detailed steps to reproduce, expected and actual Results along with screenshots/ screen recordings.

For any Magento related references, you may refer to the Magento user guide.

Thanks!