Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Set process title when running cron job #34321

Closed
5 tasks done
m2-assistant bot opened this issue Oct 12, 2021 · 4 comments · Fixed by #34186
Closed
5 tasks done

[Issue] Set process title when running cron job #34321

m2-assistant bot opened this issue Oct 12, 2021 · 4 comments · Fixed by #34186
Assignees
Labels
Area: Framework Component: Cron feature request Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 12, 2021

This issue is automatically created based on existing pull request: #34186: Set process title when running cron job


Description

When managing a busy server, it's helpful to understand what each process is doing. Currently there is no visibility for a systems administrator to see what task the bin/magento cron:run process is currently performing. The most information that's available is that some job (or set of jobs) is running within a PHP process that was started via the system task scheduler (read: cron daemon). Because of the way that Magento spawns additional processes for some groups (depending on their configuration) it is possible to sometimes narrow down the list of possible tasks because the group name is listed in the command arguments.

This pull request sets the title of the currently-running process to clearly list the group and job names.

Before screen-shot

Screenshot_2021-10-04_22-59-50

After screen-shot

Screenshot_2021-10-04_22-56-17

Related Pull Requests

None

Manual testing scenarios

  1. Run the standard Magento cron with bin/magento cron:run when several long-running tasks are scheduled
  2. Observe lack of (or presence of after this change) information about which job is running in the process tree (using tools like ps or htop on Unix - untested on Windows, but the functionality should work there too)

Questions or comments

Should the path to Magento be listed in the process title too? If there are multiple Magento instances on a single server, they should be running under different users. I can't think of a sensible non-development environment where multiple Magento instances run under the same system user.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Cron Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Oct 12, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Oct 12, 2021
@engcom-November engcom-November self-assigned this Nov 4, 2022
@m2-assistant
Copy link
Author

m2-assistant bot commented Nov 4, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

engcom-November commented Nov 4, 2022

Verified the behavior on Magento 2.4-develop instance and is reproducible.
No information about which job is running in the process tree background has been observed. We are considering this as feature request as this is existing behavior of Magento.

@m2-community-project m2-community-project bot added this to Pull Request in Progress in Feature Requests Backlog Nov 4, 2022
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in High Priority Backlog Nov 4, 2022
@engcom-November engcom-November removed their assignment Nov 4, 2022
@engcom-Lima engcom-Lima added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Framework labels Feb 20, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7987 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Feb 20, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: Cron feature request Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

4 participants