Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Fix method signature #34439

Closed
5 tasks
m2-assistant bot opened this issue Oct 26, 2021 · 0 comments · Fixed by #33859
Closed
5 tasks

[Issue] Fix method signature #34439

m2-assistant bot opened this issue Oct 26, 2021 · 0 comments · Fixed by #33859
Assignees
Labels
Component: HTTP Issue: ready for confirmation Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 26, 2021

This issue is automatically created based on existing pull request: #33859: Fix method signature


Description

curl_setopt accepts mixed as value. I get an invalid type when calling these methods in the Magento\Framework\HTTP\Client\Curl:

   ERROR: InvalidArgument - app/code/My/Module/Model.php:30:73 - Argument 2 of Magento\Framework\HTTP\Client\Curl::setOption cannot be false, string value expected (see https://psalm.dev/004)
                  $subject->curlClient->setOption(CURLOPT_SSL_VERIFYHOST, true);

Manual testing scenarios

  1. Run psalm/phpstan against a class that calls Magento\Framework\HTTP\Client\Curl::setOption

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot mentioned this issue Oct 26, 2021
6 tasks
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Oct 26, 2021
@engcom-Alfa engcom-Alfa added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Oct 26, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Oct 26, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Oct 26, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Low Priority Backlog Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: HTTP Issue: ready for confirmation Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done
Projects
Development

Successfully merging a pull request may close this issue.

2 participants