Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Enforce array type in DesignTheme config processor #34440

Closed
5 tasks
m2-assistant bot opened this issue Oct 26, 2021 · 0 comments · Fixed by #34092
Closed
5 tasks

[Issue] Enforce array type in DesignTheme config processor #34440

m2-assistant bot opened this issue Oct 26, 2021 · 0 comments · Fixed by #34092
Assignees
Labels
Component: Theme Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: PR in progress

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 26, 2021

This issue is automatically created based on existing pull request: #34092: Enforce array type in DesignTheme config processor


Description (*)

Without the type check, an empty config node like <my_store /> in a config.xml breaks installation, as null is passed to the private method.

Related Pull Requests

none

Fixed Issues (if relevant)

none (can be created if desired)

Manual testing scenarios (*)

  1. create module with store specific configuration in config.xml
  2. use empty node for one store, like <my_store />
  3. run bin/magento setup:install or integration test suite

Questions or comments

Since the changed method is private, this change is 100% backwards compatible. I'm not adding a test case since not having regressions should be a sufficient merge criteria when adding types.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Oct 26, 2021
@engcom-Alfa engcom-Alfa added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Oct 26, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Oct 26, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Oct 26, 2021
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 17, 2023
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in Low Priority Backlog Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: PR in progress
Projects
Development

Successfully merging a pull request may close this issue.

2 participants