increment_id column in sales_order table too short?

[hans-vereyken]

While testing a marketplace integration we stumbled upon the fact that the 3rd party extension is expecting the increment_id to be 50 characters. It tries to save an increment_id of > 32 characters into the sales_order column. It's an easy workaround, but it feels like an oversight in the Magento core code:
Looking at all increment_id columns and there length, only sales_order.increment_id has a length of 32, all the others have a length of 50:
tablename:increment_id-field-length
sales_order:32
sales_order_grid:50
sales_shipment:50
sales_shipment_grid:50
sales_invoice:50
sales_invoice_grid:50
sales_creditmemo:50
sales_creditmemo_grid:50

The difference between sales_order an sales_order_grid bothers me the most :-)
Also increment_id columns in other modules (eg: Customer) have a length of 50.
Is it an oversight or is there a good reason for the sales_order.increment_id to be only 32 characters in length? For me it's a bug.
Thx to https://github.com/vacla He found the bug.

Preconditions (*)

1. Magento 2.4.x (2.4-develop)

Steps to reproduce (*)

1. Install certain 3rd party modules assuming sales_order.increment_id has a length of 50 characters

Expected result (*)

1. An increment_id of 50 characters is save completely

Actual result (*)

1. Only 32 characters of an increment_id of 50 characters is saved

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @hans-vereyken. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Hi @hans-vereyken,
Could you please specify the 3rd party extension which you had tried to reproduce this issue?

In fact , I checked in Data base for the columns specified with respect to table names.

Hence added the label 'Needs Update'

[hans-vereyken]

It's the Phoenix Media Tradebyte Connector module (Phoenix_TradebyteConnector), but it's proprietary, so I can't provide you the code.
The module takes the CHANNEL_ID from an order in Tradebyte (tb.one) and places it in the sales_order.increment_id field. Such a CHANNEL_ID can be 50 characters and is used as an identifier for syncing further order updates (payment, invoicing, shipment, credit memo...). It fails because the identifier saved in the increment_id is not complete due to the column is only allowing 32 characters.
We fixed it in the code by building another module on top of the Phoenix_TradebyteConnector module which sets the sales_order.increment_id to a length of 50 in the db_schema.xml file, but yet it feels like this is a bug on the Magento side since all increment_id columns in various tables, including the sales_order_grid has a length of 50 whereas the sales_order.increment_id has a length of only 32 characters.

[vacla]

@engcom-Delta I don't have access to this issue but I was the one who found this originally, could it be possible to remove "Issue: needs update" with the above answer as answer for your question

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-1778 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.