Page Builder module has very broad slider css rule that overrides all buttons on the site

[mzenner1]

Summary (*)

vendor/magento/module-page-builder/view/frontend/web/css/source/content-type/slider/_default.less
This file has an un-nested less rule for "a.button" which conflicts with all anchor tags with a class of button on an entire website (not limited to just page builder pieces).

Examples (*)

Line is highlighted below
& when (@media-common = true) {
div[data-content-type='slider'] {
visibility: hidden;

    &.slick-initialized {
        visibility: visible;
    }

    .slick-list,
    .slick-track,
    .slick-slide {
        min-height: inherit;

        > div {
            line-height: 0;
            min-height: inherit;
            overflow: hidden;
            width: 100%;
        }
    }
}

**a.button {
    -moz-appearance: button;
    -webkit-appearance: button;
    appearance: button;
    color: initial;
    padding: 10px;
    text-decoration: none;
}**

}

Proposed solution

Proposed solution is to only apply this line if the button is actually within a page builder slider template piece. See below:

& when (@media-common = true) {
div[data-content-type='slider'] {
visibility: hidden;

    &.slick-initialized {
        visibility: visible;
    }

    .slick-list,
    .slick-track,
    .slick-slide {
        min-height: inherit;

        > div {
            line-height: 0;
            min-height: inherit;
            overflow: hidden;
            width: 100%;
        }
    }

    a.button {
        -moz-appearance: button;
        -webkit-appearance: button;
        appearance: button;
        color: initial;
        padding: 10px;
        text-decoration: none;
    }
}

}

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @mzenner1. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @mzenner1,

Thank you for your report.

To speed up the processing of this issue, please provide us with the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Thanks

[mzenner1]

The initial comment has all the relevant details needed to troubleshoot the issue. It's just a matter of a stray "a.button" in a LESS file that is not nested inside a page builder element. As a result, this line of css affects all buttons on a whole website, not just page builder pieces

[engcom-Hotel]

Hi @mzenner1,

I understood your reference after checking the less file which you referred to in the description. So based on it, can you please below additional details:

1. Please confirm if this issue is happening with the Composer-based 2.4.x version or is it happening on 2.4-develop as well?
2. If you can share some screenshots like how this particular less file code is affecting whole website buttons? It’ll be faster to reproduce then.

Accordingly, I’ll proceed with this issue.

Thanks

[mzenner1]

1. This issue is happening on 2.4.x. If the same line of css appears on the 2.4-develop branch then it is happening there too.

2. There is no easy way to provide a screenshot of this issue. All this really boils down to is that you have a very broad css rule that will apply css to any and all anchor tags that have a class of "button"

a.button {
-moz-appearance: button;
-webkit-appearance: button;
appearance: button;
color: initial;
padding: 10px;
text-decoration: none;
}

The rule in question in above. The example of how this will affect a website is that it will now adding a 10 pixel padding to all a.button instances on the whole website. The purpose of that file though is to give page builder slider pieces some basic styling. This rule does not just apply to page builder sliders though. It applies to everything. My original post on this thread has the proposed solution to apply this to just page builder slider pieces

[m2-assistant]

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
     Details

     If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Echo]

Hi @mzenner1,

Thank you for your input. But I am not able to find any affect of Page Builder module on the website storefront or in any of the button as you suggested. Neither I am able to find 10px padding in any button after adding Page Builder button changes.

I need to reproduce this issue if I want to confirm it. So can you please share more details like video of the issue happening if not screenshots which can help me in reproducing this ?

Thanks

[mzenner1]

Attached is a screenshot of the issue. Using a standard anchor tag with a class of "button" has some of its css rules wiped out/overridden by the broad page builder css rule of "a.button"

This is not part of any page builder piece. It's a custom phtml file loaded on the home page but it is being affected by the page builder css.

[engcom-Echo]

Hi @mzenner1,

Thank you for providing this info.

Verified the issue and issue is reproducible on 2.4-develop with Page Builder Module. Below are the steps I did to reproduce this:

1. Enabled Page Builder from Admin Panel.
2. Created simple custom module.
3. Added anchor tag with class button.
4. The css from Page Builder Slider(app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/slider/_default.less) is affecting this custom created anchor tag. Attached screenshot of it.

This css was meant only for Page Builder Slider but it is affecting all other css element with anchor tag and class button, so confirming this issue.

Thanks

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-2074 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Echo. Thank you for verifying the issue.
Issue Available: @engcom-Echo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.