Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in exception log files for send friend feature for WebAPI tests #34864

Closed
andrewbess opened this issue Dec 22, 2021 · 2 comments · Fixed by #34862
Closed

Fix errors in exception log files for send friend feature for WebAPI tests #34864

andrewbess opened this issue Dec 22, 2021 · 2 comments · Fixed by #34862

Comments

@andrewbess
Copy link
Contributor

Description (*)

Currently we have a problem for send friend feature when WebAPI tests are run on PHP 8.1
An error with trace provided below

main.ERROR: /var/www/html/lib/internal/Magento/Framework/DataObject.php:131 strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated Trace:
handler:Magento\Framework\App\ErrorHandler
/var/www/html/lib/internal/Magento/Framework/DataObject.php:131
/var/www/html/lib/internal/Magento/Framework/Model/AbstractExtensibleModel.php:289
/var/www/html/generated/code/Magento/Catalog/Model/Product/Interceptor.php:1562
/var/www/html/app/code/Magento/Catalog/Helper/Image.php:504
/var/www/html/app/code/Magento/Catalog/Helper/Image.php:472
/var/www/html/app/code/Magento/Catalog/Helper/Image.php:539
/var/www/html/app/code/Magento/SendFriend/Model/SendFriend.php:226
/var/www/html/app/code/Magento/SendFriendGraphQl/Model/SendFriend/SendEmail.php:104
/var/www/html/app/code/Magento/SendFriendGraphQl/Model/Resolver/SendEmailToFriend.php:68
/var/www/html/lib/internal/Magento/Framework/Interception/Interceptor.php:58
/var/www/html/lib/internal/Magento/Framework/Interception/Interceptor.php:138
/var/www/html/lib/internal/Magento/Framework/Interception/Interceptor.php:153
/var/www/html/generated/code/Magento/SendFriendGraphQl/Model/Resolver/SendEmailToFriend/Interceptor.php:23
/var/www/html/lib/internal/Magento/Framework/GraphQl/Query/Resolver/PromiseFactory.php:63
/var/www/html/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php:623
/var/www/html/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php:550
/var/www/html/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php:474
/var/www/html/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php:857
GraphQL\Executor\{closure}:GraphQL\Executor\ReferenceExecutor
/var/www/html/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php:859
/var/www/html/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php:490
/var/www/html/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php:263
/var/www/html/vendor/webonyx/graphql-php/src/Executor/ReferenceExecutor.php:215
/var/www/html/vendor/webonyx/graphql-php/src/Executor/Executor.php:156
/var/www/html/vendor/webonyx/graphql-php/src/GraphQL.php:162
/var/www/html/vendor/webonyx/graphql-php/src/GraphQL.php:94
/var/www/html/lib/internal/Magento/Framework/GraphQl/Query/QueryProcessor.php:78
/var/www/html/app/code/Magento/GraphQl/Controller/GraphQl.php:181
/var/www/html/lib/internal/Magento/Framework/Interception/Interceptor.php:58
/var/www/html/lib/internal/Magento/Framework/Interception/Interceptor.php:138
/var/www/html/app/code/Magento/PageCache/Model/App/FrontController/BuiltinPlugin.php:71
/var/www/html/lib/internal/Magento/Framework/Interception/Interceptor.php:135
/var/www/html/lib/internal/Magento/Framework/Interception/Interceptor.php:153
/var/www/html/generated/code/Magento/GraphQl/Controller/GraphQl/Interceptor.php:23
/var/www/html/lib/internal/Magento/Framework/App/Http.php:116
/var/www/html/generated/code/Magento/Framework/App/Http/Interceptor.php:23
/var/www/html/lib/internal/Magento/Framework/App/Bootstrap.php:264
/var/www/html/pub/index.php:30
{"exception":true} []

The problem is related to new deprecations in PHP 8.1.

We need to research and fix the problem.

Expected result (*)

  1. An exception.log files don't contain provided error

Actual result (*)

  1. An exception.log files contain provided error
@m2-assistant
Copy link

m2-assistant bot commented Dec 22, 2021

Hi @andrewbess. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Dec 22, 2021

Hi @andrewbess. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant